Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: corelib/src/implementation/print.dart

Issue 10868043: Move print to corelib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make it pass all tests. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: corelib/src/implementation/print.dart
diff --git a/runtime/tests/vm/dart/mysrc/test3a.dart b/corelib/src/implementation/print.dart
similarity index 79%
copy from runtime/tests/vm/dart/mysrc/test3a.dart
copy to corelib/src/implementation/print.dart
index f0873ab4549dd7fc85d7e7b55a14be01e42451ff..1110053ec8b02907b82c5c9606eed69b9cc55095 100644
--- a/runtime/tests/vm/dart/mysrc/test3a.dart
+++ b/corelib/src/implementation/print.dart
@@ -2,6 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-int test3a() {
- return 3;
+class Logger {
Anders Johnsen 2012/08/28 13:53:10 The name 'Logger' seams very generic. Can we pick
Mads Ager (google) 2012/08/28 13:57:29 Sure. We can call it PrintImplementation? We can d
Anders Johnsen 2012/08/28 14:01:09 PrintImplementation sounds good, I'm afraid we'll
Ivan Posva 2012/08/29 06:21:16 The conflicts with other user code would only happ
Anders Johnsen 2012/08/29 06:54:07 True, but I actually have code where i have my own
+ external static void print(Object obj);
}

Powered by Google App Engine
This is Rietveld 408576698