Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 10866015: Don't leak render thread on Stop(). (Closed)

Created:
8 years, 4 months ago by DaleCurtis
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Don't leak render thread on Stop(). Noticed this while refactoring. BUG=none TEST=drmemory windows. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152786

Patch Set 1 : #include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M media/audio/win/audio_low_latency_output_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
DaleCurtis
8 years, 4 months ago (2012-08-22 03:41:12 UTC) #1
henrika (OOO until Aug 14)
LGTM, thanks Dale! Can you add some details regarding drmemory and how you run it ...
8 years, 4 months ago (2012-08-22 09:29:55 UTC) #2
henrika (OOO until Aug 14)
Found http://www.chromium.org/developers/how-tos/using-drmemory
8 years, 4 months ago (2012-08-22 09:30:41 UTC) #3
DaleCurtis
On 2012/08/22 09:30:41, henrika wrote: > Found http://www.chromium.org/developers/how-tos/using-drmemory That's the one, there's also a try ...
8 years, 4 months ago (2012-08-22 17:02:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/10866015/2001
8 years, 4 months ago (2012-08-22 17:02:43 UTC) #5
commit-bot: I haz the power
Try job failure for 10866015-2001 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=49766 Step "update" is always ...
8 years, 4 months ago (2012-08-22 17:04:33 UTC) #6
DaleCurtis
8 years, 4 months ago (2012-08-22 17:07:02 UTC) #7
On 2012/08/22 17:04:33, I haz the power (commit-bot) wrote:
> Try job failure for 10866015-2001 on mac_rel for step "update".
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
> 
> Step "update" is always a major failure.
> Look at the try server FAQ for more details.

Argh, it's flaking on a whitespace change.

Powered by Google App Engine
This is Rietveld 408576698