Issue 10865002: Revert 150969 - Disable getting histogram data from child processes other than the renderer process…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10865002: Revert 150969 - Disable getting histogram data from child processes other than the renderer process… (Closed)

Created:
8 years, 4 months ago by ramant (doing other things)

Modified:
8 years, 4 months ago

Reviewers:
rtenneti, jar (doing other things)

CC:
chromium-reviews, MAD, jar (doing other things), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, erikwright+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 150969 - Disable getting histogram data from child processes other than the renderer processes. Store the histogram name in the local variable for debugging purposes when we crash. R=jar TBR=jam BUG=140688 TEST=base (histogram unit tests) and unit_tests. Review URL: https://chromiumcodereview.appspot.com/10831247 TBR=rtenneti@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152427

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	base/metrics/histogram_snapshot_manager.cc	View		2 chunks	+0 lines, -9 lines	0 comments	Download
	M	content/browser/histogram_controller.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

8 years, 4 months ago (2012-08-20 23:42:35 UTC) #2

Hi Jim,
  I am reverting the change that commented out uploading histogram data from
child processes. The real problem was initializing of StatisticsRecorder in
renderer process. In Dev, we didn't disable getting histogram data from child
processes and we don't have any crashes. So reverting this change in Canary.

thanks
raman

Expand Messages | Collapse Messages