Issue 10831247: Disable getting histogram data from child processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831247: Disable getting histogram data from child processes. (Closed)

Created:
8 years, 4 months ago by ramant (doing other things)

Modified:
8 years, 4 months ago

Reviewers:
jam, jar (doing other things)

CC:
chromium-reviews, MAD, jar (doing other things), erikwright (departed), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Ilya Sherman

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disable getting histogram data from child processes other than the renderer processes. Store the histogram name in the local variable for debugging purposes when we crash. R=jar TBR=jam BUG=140688 TEST=base (histogram unit tests) and unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150969

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	base/metrics/histogram_snapshot_manager.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
	M	content/browser/histogram_controller.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10831247/5001

8 years, 4 months ago (2012-08-10 00:17:03 UTC) #4

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

8 years, 4 months ago (2012-08-10 01:26:01 UTC) #6

commit-bot: I haz the power

8 years, 4 months ago (2012-08-10 01:41:25 UTC) #7

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10831247/5001

Expand Messages | Collapse Messages