chrome/renderer/extensions/user_script_scheduler.cc - Issue 10863002: Added check to prevent extensions from injecting scrips into other extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/user_script_scheduler.cc

Issue 10863002: Added check to prevent extensions from injecting scrips into other extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added test cases for self injection... and failed injection attempt Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.h ('K') | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/renderer/extensions/user_script_slave.cc » ('j') | chrome/renderer/extensions/user_script_slave.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/user_script_scheduler.cc

diff --git a/chrome/renderer/extensions/user_script_scheduler.cc b/chrome/renderer/extensions/user_script_scheduler.cc

index 4a561157f3891413ac2643849bac392127ae9fbf..5590da49802fde44466963ac666f90273f991037 100644

--- a/chrome/renderer/extensions/user_script_scheduler.cc

+++ b/chrome/renderer/extensions/user_script_scheduler.cc

@@ -174,6 +174,7 @@ void UserScriptScheduler::ExecuteCodeImpl(

// For child frames, we just skip ones the extension doesn't have access

// to and carry on.

if (!extension->CanExecuteScriptOnPage(frame->document().url(),

+ frame_->document().url(),

extension_helper->tab_id(),

abarth-chromium 2012/08/22 00:54:19 Having frame and frame_ be different variables is

zel 2012/08/22 01:39:20 Done.

NULL,

NULL)) {