Added check to prevent extensions from injecting scrips into other extensions

chrome/renderer/extensions/user_script_scheduler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/user_script_scheduler.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "chrome/common/extensions/extension_error_utils.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
@@ skipping 156 matching lines @@
       // with navigation.
       //
       // But different frames can have different URLs, and the extension might
       // only have access to a subset of them. For the top frame, we can
       // immediately send an error and stop because the browser process
       // considers that an error too.
       //
       // For child frames, we just skip ones the extension doesn't have access
       // to and carry on.
       if (!extension->CanExecuteScriptOnPage(frame->document().url(),
+                                             frame_->document().url(),
                                              extension_helper->tab_id(),

[abarth-chromium, 2012/08/22 00:54:19]

Having frame and frame_ be different variables is really confusing.  Perhaps we
should call frame child_frame?

[zel, 2012/08/22 01:39:20]

Done.

                                              NULL,
                                              NULL)) {
         if (frame->parent()) {
           continue;
         } else {
           render_view->Send(new ExtensionHostMsg_ExecuteCodeFinished(
               render_view->GetRoutingID(),
               params.request_id,
               ExtensionErrorUtils::FormatErrorMessage(
                   extension_manifest_errors::kCannotAccessPage,
@@ skipping 62 matching lines @@
 
   for (WebFrame* child_frame = parent_frame->firstChild(); child_frame;
        child_frame = child_frame->nextSibling()) {
     frames_vector->push_back(child_frame);
     GetAllChildFrames(child_frame, frames_vector);
   }
   return true;
 }
 
 }  // namespace extensions