Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 10861038: Revert 152609 - Integrate invalidation API into ChromeToMobileService. (Closed)

Created:
8 years, 4 months ago by msw
Modified:
8 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert 152609 - Integrate invalidation API into ChromeToMobileService. Failed? Win7 Tests (dbg)(6) browser_tests InProcessBrowserTest.Empty: http://build.chromium.org/p/chromium/builders/Win7%20Tests%20%28dbg%29%286%29/builds/10278/steps/browser_tests/logs/stdio Update chrome/browser/DEPS with new dependencies: (google/cacheinvalidation and sync/notifier) Observe Sync Notifier invalidation notifications: (depend on this service for mobile list updates) (refresh the device list on cloud print invalidation) Remove RequestMobileListUpdate, timestamp, & account info: (no longer needed with invalidation integration) (just set command state and icon visibility w/HasMobiles) Lazily init the access token, queue search/send operations: (only get an access token as needed, add |task_queue_|) Allow concurrent cloud print device search requests: (handle user-triggered updates while fetching the list) Misc cleanup (CloudPrintUrl handling, tests, etc.) TODO(followup): Additional logging, tests, invalidation ack. BUG=102709, 137086 Review URL: https://chromiumcodereview.appspot.com/10834203 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -186 lines) Patch
M chrome/browser/DEPS View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.h View 8 chunks +20 lines, -29 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 13 chunks +120 lines, -119 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_unittest.cc View 2 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller_unittest.mm View 7 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
MM chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/common/pref_names.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
msw
8 years, 4 months ago (2012-08-21 20:01:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698