Issue 10861002: Revert 152213 - Replace the DownloadFileManager with direct ownership of DownloadFile.

Issue 10861002: Revert 152213 - Replace the DownloadFileManager with direct ownership of DownloadFile. (Closed)

Created:
8 years, 4 months ago by Randy Smith (Not in Mondays)

Modified:
8 years, 4 months ago

Reviewers:
benjhayden, Randy Smith (Not in Mondays)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, rginda+watch_chromium.org, jam, rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 152213 - Replace the DownloadFileManager with direct ownership of DownloadFile. This CL is a re-land of http://codereview.chromium.org/10799005, which was reverted due to test flakiness. BUG=123998 R=benjhayden@chromium.org TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10836293 BUG=143600 TBR=rdsmith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152282

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+825 lines, -1008 lines)			Patch
M	chrome/browser/download/download_browsertest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/browser_context.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/download/base_file.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/download/base_file.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/download/download_file.h	View	4 chunks	+11 lines, -13 lines	0 comments	Download
D	content/browser/download/download_file_factory.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	content/browser/download/download_file_factory.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	content/browser/download/download_file_impl.h	View	5 chunks	+25 lines, -22 lines	0 comments	Download
M	content/browser/download/download_file_impl.cc	View	8 chunks	+64 lines, -65 lines	0 comments	Download
A +	content/browser/download/download_file_manager.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/download/download_file_manager.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/download/download_file_manager_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/browser/download/download_file_unittest.cc	View	16 chunks	+83 lines, -66 lines	0 comments	Download
M	content/browser/download/download_item_impl.h	View	9 chunks	+16 lines, -38 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View	14 chunks	+42 lines, -171 lines	0 comments	Download
M	content/browser/download/download_item_impl_delegate.h	View	1 chunk	+2 lines, -12 lines	0 comments	Download
M	content/browser/download/download_item_impl_delegate.cc	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	content/browser/download/download_item_impl_unittest.cc	View	22 chunks	+78 lines, -165 lines	0 comments	Download
M	content/browser/download/download_manager_impl.h	View	9 chunks	+27 lines, -23 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	17 chunks	+141 lines, -57 lines	0 comments	Download
M	content/browser/download/download_manager_impl_unittest.cc	View	18 chunks	+81 lines, -60 lines	0 comments	Download
M	content/browser/download/download_resource_handler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/download/mock_download_file.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/download/mock_download_file.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	content/browser/download/save_package.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_impl.h	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_impl.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	content/public/browser/download_destination_observer.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	content/public/browser/download_manager.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	content/public/test/mock_download_manager.h	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	content/public/test/test_file_error_injector.h	View	6 chunks	+16 lines, -18 lines	0 comments	Download
M	content/public/test/test_file_error_injector.cc	View	13 chunks	+169 lines, -151 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages