content/browser/download/download_file_manager_unittest.cc - Issue 10861002: Revert 152213 - Replace the DownloadFileManager with direct ownership of DownloadFile.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/download/download_file_manager_unittest.cc

Issue 10861002: Revert 152213 - Replace the DownloadFileManager with direct ownership of DownloadFile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « content/browser/download/download_file_manager.cc ('k') | content/browser/download/download_file_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/download/download_file_manager.h"	5 #include "content/browser/download/download_file_manager.h"

6	6

7 #include "base/file_path.h"	7 #include "base/file_path.h"

8 #include "base/file_util.h"	8 #include "base/file_util.h"

9 #include "base/message_loop.h"	9 #include "base/message_loop.h"

10 #include "base/scoped_temp_dir.h"	10 #include "base/scoped_temp_dir.h"

(...skipping 393 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
404	404

405 CleanUp(dummy_id);	405 CleanUp(dummy_id);

406 }	406 }

407	407

408 // TODO(ahendrickson) -- A test for download manager shutdown.	408 // TODO(ahendrickson) -- A test for download manager shutdown.

409 // Expected call sequence:	409 // Expected call sequence:

410 // OnDownloadManagerShutdown	410 // OnDownloadManagerShutdown

411 // DownloadFile::GetDownloadManager	411 // DownloadFile::GetDownloadManager

412 // DownloadFile::CancelDownloadRequest	412 // DownloadFile::CancelDownloadRequest

413 // DownloadFile::~DownloadFile	413 // DownloadFile::~DownloadFile

OLD	NEW