Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 10860053: Reland 152221 - chromeos: Sync animation. (Closed)

Created:
8 years, 4 months ago by xiyuan
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, not at google - send to devlin
Visibility:
Public.

Description

Reland 152221 - chromeos: Sync animation. - Pulse app list button while LauncherModel has STATUS_LOADING; - Remove LauncherItemStatus::STATUS_IS_PENDING etc since it is no longer needed; - ChromeLauncherController sets LauncherModel::STATUS_LOADING on starting and watch for sync finish and pending extension install. It sets LauncherModel::STATUS_NORMAL when sync is finished and there is no pending extension install from sync, or when a maximum 60 seconds timeout since turning on loading status; BUG=129236 TEST=Verify sync animation after OOBE. TBR=sky@chromium.org, kalman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152684

Patch Set 1 #

Patch Set 2 : fix broken browser_tests #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -276 lines) Patch
M ash/ash_strings.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/launcher/app_list_button.h View 2 chunks +4 lines, -1 line 0 comments Download
M ash/launcher/app_list_button.cc View 1 chunk +88 lines, -10 lines 0 comments Download
M ash/launcher/launcher_button.h View 4 chunks +1 line, -11 lines 0 comments Download
M ash/launcher/launcher_button.cc View 6 chunks +1 line, -106 lines 0 comments Download
M ash/launcher/launcher_model.h View 3 chunks +10 lines, -0 lines 0 comments Download
M ash/launcher/launcher_model.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M ash/launcher/launcher_model_observer.h View 1 chunk +4 lines, -1 line 0 comments Download
M ash/launcher/launcher_model_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/launcher/launcher_types.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/launcher/launcher_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/launcher/launcher_view.cc View 7 chunks +17 lines, -36 lines 0 comments Download
M ash/launcher/launcher_view_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 2 3 8 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 11 chunks +85 lines, -48 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +15 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
r152221 breaks a bunch of browser_tests: ExtensionTabsTest.GetAllWindows ExtensionTabsTest.DefaultToIncognitoWhenItIsForced ExtensionTabsTest.DefaultToIncognitoWhenItIsForcedAndNoArgs ExtensionTabsTest.QueryCurrentWindowTabs ExtensionApiNewTabTest.Tabs ExtensionApiTest.Tabs2 BrowserCloseTest.DownloadsCloseCheck_2 BrowserCloseTest.DownloadsCloseCheck_3 BrowserCloseTest.DownloadsCloseCheck_4 ...
8 years, 4 months ago (2012-08-20 22:48:40 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-20 23:14:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10860053/2001
8 years, 4 months ago (2012-08-21 16:27:05 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/ash/launcher/chrome_launcher_controller.h: While running patch -p1 --forward --force; patching file chrome/browser/ui/ash/launcher/chrome_launcher_controller.h ...
8 years, 4 months ago (2012-08-21 16:27:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10860053/12003
8 years, 4 months ago (2012-08-21 21:52:51 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 00:19:12 UTC) #6
Change committed as 152684

Powered by Google App Engine
This is Rietveld 408576698