Issue 10860031: Cleanup: Remove empty array param from chrome.send('x', []).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10860031: Cleanup: Remove empty array param from chrome.send('x', []). (Closed)

Created:
8 years, 4 months ago by James Hawkins

Modified:
8 years, 4 months ago

Reviewers:
csilv

CC:
chromium-reviews, dcheng, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleanup: Remove empty array param from chrome.send('x', []). Fixed a few lint issues in these files as well. BUG=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152270

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -52 lines)			Patch
M	chrome/browser/resources/about_conflicts.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/about_conflicts.js	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/about_flash.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/about_flash.js	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/host_registration_page.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/network_dropdown.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/menu.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/menu.js	View	13 chunks	+34 lines, -38 lines	0 comments	Download

Total messages: 3 (0 generated)

csilv

lgtm nit: edit comment to indicate that you did other style cleanups as well.

8 years, 4 months ago (2012-08-18 19:32:23 UTC) #2

James Hawkins

8 years, 4 months ago (2012-08-18 23:33:32 UTC) #3

On 2012/08/18 19:32:23, csilv wrote:
> lgtm
> 
> nit: edit comment to indicate that you did other style cleanups as well.

Done.