Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2560)

Unified Diff: chrome/browser/resources/about_conflicts.js

Issue 10860031: Cleanup: Remove empty array param from chrome.send('x', []). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_conflicts.html ('k') | chrome/browser/resources/about_flash.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/about_conflicts.js
diff --git a/chrome/browser/resources/about_conflicts.js b/chrome/browser/resources/about_conflicts.js
index f49365ff92b0c4dcd31bcf7e8706edebb6e15e95..e8eb92ea557131d30b6dc87642165ee3174706b6 100644
--- a/chrome/browser/resources/about_conflicts.js
+++ b/chrome/browser/resources/about_conflicts.js
@@ -30,12 +30,12 @@ var moduleListDataFormat = {
* Takes the |moduleListData| input argument which represents data about
* the currently available modules and populates the html jstemplate
* with that data. It expects an object structure like the above.
-* @param {Object} moduleListData Information about available modules
+* @param {Object} moduleListData Information about available modules.
*/
function renderTemplate(moduleListData) {
// This is the javascript code that processes the template:
var input = new JsEvalContext(moduleListData);
- var output = document.getElementById('modulesTemplate');
+ var output = $('modulesTemplate');
jstProcess(input, output);
}
@@ -45,17 +45,18 @@ function renderTemplate(moduleListData) {
* should reply to returnModuleList() (below).
*/
function requestModuleListData() {
- chrome.send('requestModuleList', []);
+ chrome.send('requestModuleList');
}
/**
* Called by the WebUI to re-populate the page with data representing the
* current state of installed modules.
+* @param {Object} moduleListData Information about available modules.
*/
function returnModuleList(moduleListData) {
renderTemplate(moduleListData);
- document.getElementById('loading-message').style.visibility = 'hidden';
- document.getElementById('body-container').style.visibility = 'visible';
+ $('loading-message').style.visibility = 'hidden';
+ $('body-container').style.visibility = 'visible';
}
// Get data and have it displayed upon loading.
« no previous file with comments | « chrome/browser/resources/about_conflicts.html ('k') | chrome/browser/resources/about_flash.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698