Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc

Issue 10860017: Refactor Metrics (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Nitfix + latest master for cq Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/performance_monitor/performance_monitor_util_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc
diff --git a/chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc b/chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc
index 373125c830c01331cfa78c5a05064bdcc7330871..cd7bc8f59e7b7c5e21c90bfc270e730272756006 100644
--- a/chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc
+++ b/chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc
@@ -10,6 +10,7 @@
#include "base/values.h"
#include "chrome/browser/performance_monitor/database.h"
#include "chrome/browser/performance_monitor/event.h"
+#include "chrome/browser/performance_monitor/metric.h"
#include "chrome/browser/performance_monitor/metric_details.h"
#include "chrome/browser/performance_monitor/performance_monitor.h"
#include "chrome/browser/performance_monitor/performance_monitor_util.h"
@@ -42,10 +43,10 @@ void DoGetActiveIntervals(ListValue* results,
void DoGetEvents(ListValue* results, EventType event_type,
const base::Time& start, const base::Time& end) {
Database* db = PerformanceMonitor::GetInstance()->database();
- std::vector<linked_ptr<Event> > events =
+ Database::EventVector events =
Evan Stade 2012/08/23 00:04:55 seems like you don't need this line return
db->GetEvents(event_type, start, end);
- for (std::vector<linked_ptr<Event> >::iterator it = events.begin();
+ for (Database::EventVector::iterator it = events.begin();
it != events.end(); ++it) {
results->Append((*it)->data()->DeepCopy());
}
@@ -61,14 +62,14 @@ void DoGetMetric(ListValue* results,
Database::MetricVectorMap metric_vector_map =
db->GetStatsForMetricByActivity(metric_type, start, end);
- linked_ptr<Database::MetricInfoVector> metric_vector =
+ linked_ptr<Database::MetricVector> metric_vector =
metric_vector_map[kProcessChromeAggregate];
if (!metric_vector.get())
- metric_vector.reset(new Database::MetricInfoVector());
+ metric_vector.reset(new Database::MetricVector());
- Database::MetricInfoVector aggregated_metrics =
+ Database::MetricVector aggregated_metrics =
util::AggregateMetric(*metric_vector, start, resolution);
- for (Database::MetricInfoVector::iterator it = aggregated_metrics.begin();
+ for (Database::MetricVector::const_iterator it = aggregated_metrics.begin();
it != aggregated_metrics.end(); ++it) {
DictionaryValue* metric_value = new DictionaryValue();
metric_value->SetDouble("time", it->time.ToJsTime());
« no previous file with comments | « chrome/browser/performance_monitor/performance_monitor_util_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698