Add comments to HistogramFlatterner interface and rename a function

Add comments to HistogramFlatterner interface and rename a function

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152434

[kaiwang, 2012-08-18 05:08:39]

As we discussed last time, these functions are quite hard to understand...

[jar (doing other things), 2012-08-20 02:41:49]

http://codereview.chromium.org/10857067/diff/1/base/metrics/histogram_flatten...
File base/metrics/histogram_flattener.h (right):

http://codereview.chromium.org/10857067/diff/1/base/metrics/histogram_flatten...
base/metrics/histogram_flattener.h:25: // Will be called each time when a type
of Inconsistenies is seen on a
nit: remove either "each time" or "when".

Clarify the passive voice "Will be" by clarifying who/when the call is made. 
Suggest adding the postfix to your sentence:
"... during inspections done internally to the RecordDelta() method."

http://codereview.chromium.org/10857067/diff/1/base/metrics/histogram_flatten...
base/metrics/histogram_flattener.h:30: // on a histogram.
nit: clarify who/when this is called, such as was suggested above"

http://codereview.chromium.org/10857067/diff/1/base/metrics/histogram_flatten...
base/metrics/histogram_flattener.h:35: // inconsistency. |amount| is the
difference.
nit: Clarify this line, possibly by replacing the whole comment with:

Will be called by RecordDelta() when the logged sample count for the entire
histogram differs from the sum of the sample count in all the buckets.  The
argument |amount| is the non-zero discrepancy.

[jar (doing other things), 2012-08-20 17:42:07]

lgtm

[commit-bot: I haz the power, 2012-08-20 17:52:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10857067/7003

[commit-bot: I haz the power, 2012-08-20 17:52:32]

Presubmit check for 10857067-7003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    content/common

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[kaiwang, 2012-08-20 19:48:54]

Hi reviewers, I'll need LGTM on:
chrome/common/metrics/
AND
content/common/

Thanks a lot!

[jam, 2012-08-20 20:12:01]

lgtm

[commit-bot: I haz the power, 2012-08-20 20:22:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10857067/7003

[commit-bot: I haz the power, 2012-08-20 20:39:54]

Try job failure for 10857067-7003 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-08-20 21:21:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10857067/5005

[commit-bot: I haz the power, 2012-08-20 23:53:16]

Change committed as 152434