Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: content/common/child_histogram_message_filter.cc

Issue 10857067: Add comments to HistogramFlatterner interface and rename a function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/child_histogram_message_filter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/child_histogram_message_filter.cc
===================================================================
--- content/common/child_histogram_message_filter.cc (revision 151415)
+++ content/common/child_histogram_message_filter.cc (working copy)
@@ -81,17 +81,20 @@
pickled_histograms_.push_back(histogram_info);
}
-void ChildHistogramMessageFilter::InconsistencyDetected(int problem) {
+void ChildHistogramMessageFilter::InconsistencyDetected(
+ base::Histogram::Inconsistencies problem) {
UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesChildProcess",
problem, base::Histogram::NEVER_EXCEEDED_VALUE);
}
-void ChildHistogramMessageFilter::UniqueInconsistencyDetected(int problem) {
+void ChildHistogramMessageFilter::UniqueInconsistencyDetected(
+ base::Histogram::Inconsistencies problem) {
UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesChildProcessUnique",
problem, base::Histogram::NEVER_EXCEEDED_VALUE);
}
-void ChildHistogramMessageFilter::SnapshotProblemResolved(int amount) {
+void ChildHistogramMessageFilter::InconsistencyDetectedInLoggedCount(
+ int amount) {
UMA_HISTOGRAM_COUNTS("Histogram.InconsistentSnapshotChildProcess",
std::abs(amount));
}
« no previous file with comments | « content/common/child_histogram_message_filter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698