Issue 10857065: Revert 152162 - Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMem…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857065: Revert 152162 - Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMem… (Closed)

Created:
8 years, 4 months ago by pkotwicz

Modified:
8 years, 4 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 152162 - Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory> instead of std::vector<unsigned char> Bug=138553 Test=Compiles R=michaelbai TBR=sky Review URL: https://chromiumcodereview.appspot.com/10831341 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152169

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -25 lines)			Patch
M	chrome/browser/history/android/android_history_types.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/history/android/android_provider_backend.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
MM	chrome/browser/history/android/android_provider_backend_unittest.cc	View	9 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/history/android/favicon_sql_handler.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)