Issue 10831341: Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831341: Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory> (Closed)

Created:
8 years, 4 months ago by pkotwicz

Modified:
8 years, 4 months ago

Reviewers:
michaelbai, sky

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory> instead of std::vector<unsigned char> Bug=138553 Test=Compiles R=michaelbai TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152193

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -22 lines)			Patch
M	chrome/browser/history/android/android_history_types.h	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/history/android/android_provider_backend.cc	View	1 2 3	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/history/android/android_provider_backend_unittest.cc	View	1 2	9 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/history/android/favicon_sql_handler.cc	View		3 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 5 (0 generated)

pkotwicz

Michael can you please take a look? I use the changes in this CL in ...

8 years, 4 months ago (2012-08-16 02:22:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10831341/5003

8 years, 4 months ago (2012-08-17 21:26:59 UTC) #4

yongsheng

8 years, 4 months ago (2012-08-20 09:58:01 UTC) #5

This patch causes one regression. See the patch:
http://codereview.chromium.org/10861006/
@michaelbai and @pkotwicz, could you please help review it?