Upgrade DCHECK(pending_callbacks_.get()) to CHECK().

Upgrade DCHECK(pending_callbacks_.get()) to CHECK().

Collecting data to track down use-after-free crashes when executing callbacks in media::Pipeline.

BUG=143440
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152236

[jar (doing other things), 2012-08-18 00:48:28]

lgtm

[scherkus (not reviewing), 2012-08-18 00:48:59]

FYI this might not be needed as I landed a tentative fix r152192

[jar (doing other things), 2012-08-18 00:52:54]

On 2012/08/18 00:48:59, scherkus wrote:
> FYI this might not be needed as I landed a tentative fix r152192

Understood.

This was a painful bug... I saw Raman spotted the unretained... and it sounded
like you also spotted multiple inheritance of ref-counting.  Either of which
sound like causes of bad problems.

That said, it is probably better to land this, and get more data asap, just in
case.  You can revert this next week easily, but it would be better to avoid
serializing elements of the search (given it is a critical bug).   If you want,
you could add TODO lines... and create a tickler bug to do the revert... but
just planning on the mini-revert next week seems simple enough.

[scherkus (not reviewing), 2012-08-18 01:01:37]

SGTM

[commit-bot: I haz the power, 2012-08-18 01:02:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/10857062/1

[scherkus (not reviewing), 2012-08-18 01:04:27]

FYI I filed https://code.google.com/p/chromium/issues/detail?id=143539 so I
don't forget about reverting :)

[commit-bot: I haz the power, 2012-08-18 03:23:10]

Change committed as 152236