Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: media/base/pipeline.cc

Issue 10857062: Upgrade DCHECK(pending_callbacks_.get()) to CHECK(). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.cc
diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc
index 4d303190da878fdbeaef68778fc6452a568e79f1..a27bfc3d4af78bb015f2e5d5e68601bb181acb8e 100644
--- a/media/base/pipeline.cc
+++ b/media/base/pipeline.cc
@@ -424,7 +424,7 @@ TimeDelta Pipeline::TimeForByteOffset_Locked(int64 byte_offset) const {
void Pipeline::DoPause(const PipelineStatusCB& done_cb) {
DCHECK(message_loop_->BelongsToCurrentThread());
- DCHECK(!pending_callbacks_.get());
+ CHECK(!pending_callbacks_.get());
SerialRunner::Queue bound_fns;
if (audio_renderer_)
@@ -438,7 +438,7 @@ void Pipeline::DoPause(const PipelineStatusCB& done_cb) {
void Pipeline::DoFlush(const PipelineStatusCB& done_cb) {
DCHECK(message_loop_->BelongsToCurrentThread());
- DCHECK(!pending_callbacks_.get());
+ CHECK(!pending_callbacks_.get());
SerialRunner::Queue bound_fns;
if (audio_renderer_)
@@ -452,7 +452,7 @@ void Pipeline::DoFlush(const PipelineStatusCB& done_cb) {
void Pipeline::DoPlay(const PipelineStatusCB& done_cb) {
DCHECK(message_loop_->BelongsToCurrentThread());
- DCHECK(!pending_callbacks_.get());
+ CHECK(!pending_callbacks_.get());
SerialRunner::Queue bound_fns;
if (audio_renderer_)
@@ -466,7 +466,7 @@ void Pipeline::DoPlay(const PipelineStatusCB& done_cb) {
void Pipeline::DoStop(const PipelineStatusCB& done_cb) {
DCHECK(message_loop_->BelongsToCurrentThread());
- DCHECK(!pending_callbacks_.get());
+ CHECK(!pending_callbacks_.get());
SerialRunner::Queue bound_fns;
if (demuxer_)
@@ -877,7 +877,7 @@ void Pipeline::AudioDisabledTask() {
void Pipeline::FilterStateTransitionTask() {
DCHECK(message_loop_->BelongsToCurrentThread());
- DCHECK(pending_callbacks_.get())
+ CHECK(pending_callbacks_.get())
<< "Filter state transitions must be completed via pending_callbacks_";
pending_callbacks_.reset();
@@ -1197,7 +1197,7 @@ void Pipeline::DoSeek(base::TimeDelta seek_timestamp,
bool skip_demuxer_seek,
const PipelineStatusCB& done_cb) {
DCHECK(message_loop_->BelongsToCurrentThread());
- DCHECK(!pending_callbacks_.get());
+ CHECK(!pending_callbacks_.get());
SerialRunner::Queue bound_fns;
if (!skip_demuxer_seek) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698