Make FaviconService a ProfileKeyedService

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index 34b30d98b984260434fa7ceea8fdad6a210dfde3..7963b80f4770a4954e322a927268935756aff3c6 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -41,6 +41,7 @@
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/user_script_master.h"
 #include "chrome/browser/favicon/favicon_service.h"
+#include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/geolocation/chrome_geolocation_permission_context.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/history_service_factory.h"
@@ -716,11 +717,7 @@ content::ResourceContext* ProfileImpl::GetResourceContext() {
 }
 
 FaviconService* ProfileImpl::GetFaviconService(ServiceAccessType sat) {

[Elliot Glaysher, 2012/08/16 19:37:49]

This is OK as long as you plan to come back and pull the Profile::Get accessor
out.

[andreip3000, 2012/08/17 09:34:57]

Yes, that's my next patch. I looked into doing this now but there are about 28
callsites for this accessor. Torne suggested taking them out in a follow-up
patch.

-  if (!favicon_service_created_) {
-    favicon_service_created_ = true;
-    favicon_service_.reset(new FaviconService(this));
-  }
-  return favicon_service_.get();
+  return FaviconServiceFactory::GetForProfile(this);
 }
 
 net::URLRequestContextGetter* ProfileImpl::GetRequestContextForExtensions() {