Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10857021: Prepare a bunch of ash tests for workspace2. With Workspace2 you can't (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Prepare a bunch of ash tests for workspace2. With Workspace2 you can't add to the default container, instead you need to go through the StackingClient. BUG=137342 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -182 lines) Patch
M ash/accelerators/accelerator_filter_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M ash/focus_cycler_unittest.cc View 6 chunks +6 lines, -24 lines 0 comments Download
M ash/launcher/launcher_context_menu_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell_unittest.cc View 7 chunks +15 lines, -8 lines 0 comments Download
M ash/wm/activation_controller_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M ash/wm/frame_painter.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/wm/frame_painter_unittest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 5 chunks +5 lines, -25 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 10 chunks +35 lines, -63 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_filter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 3 chunks +13 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/wm/workspace_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller_test_helper.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller_test_helper.cc View 2 chunks +6 lines, -1 line 0 comments Download
M ui/aura/client/stacking_client.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
8 years, 4 months ago (2012-08-15 22:51:22 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-15 23:46:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10857021/1
8 years, 4 months ago (2012-08-15 23:49:57 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 04:28:38 UTC) #4 
Change committed as 151848

Powered by Google App Engine
This is Rietveld 408576698