Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2735)

Unified Diff: ash/wm/window_animations_unittest.cc

Issue 10857021: Prepare a bunch of ash tests for workspace2. With Workspace2 you can't (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_animations_unittest.cc
diff --git a/ash/wm/window_animations_unittest.cc b/ash/wm/window_animations_unittest.cc
index 7768b18ed72335587b22fd3f33bf3f388e896cfe..0a5f62569d2767c6ca48f3359436339e751ec6ca 100644
--- a/ash/wm/window_animations_unittest.cc
+++ b/ash/wm/window_animations_unittest.cc
@@ -22,12 +22,8 @@ namespace internal {
typedef ash::test::AshTestBase WindowAnimationsTest;
TEST_F(WindowAnimationsTest, HideShow) {
- aura::Window* default_container =
- ash::Shell::GetContainer(
- Shell::GetPrimaryRootWindow(),
- internal::kShellWindowId_DefaultContainer);
scoped_ptr<aura::Window> window(
- aura::test::CreateTestWindowWithId(0, default_container));
+ aura::test::CreateTestWindowWithId(0, NULL));
window->Show();
EXPECT_TRUE(window->layer()->visible());
// Hiding.
@@ -60,12 +56,8 @@ TEST_F(WindowAnimationsTest, HideShow) {
}
TEST_F(WindowAnimationsTest, ShowHide) {
- aura::Window* default_container =
- ash::Shell::GetContainer(
- Shell::GetPrimaryRootWindow(),
- internal::kShellWindowId_DefaultContainer);
scoped_ptr<aura::Window> window(
- aura::test::CreateTestWindowWithId(0, default_container));
+ aura::test::CreateTestWindowWithId(0, NULL));
window->Show();
EXPECT_TRUE(window->layer()->visible());
// Showing -- should be a no-op.
@@ -98,12 +90,8 @@ TEST_F(WindowAnimationsTest, ShowHide) {
}
TEST_F(WindowAnimationsTest, HideShowBrightnessGrayscaleAnimation) {
- aura::Window* default_container =
- ash::Shell::GetContainer(
- Shell::GetPrimaryRootWindow(),
- internal::kShellWindowId_DefaultContainer);
scoped_ptr<aura::Window> window(
- aura::test::CreateTestWindowWithId(0, default_container));
+ aura::test::CreateTestWindowWithId(0, NULL));
window->Show();
EXPECT_TRUE(window->layer()->visible());
@@ -139,12 +127,8 @@ TEST_F(WindowAnimationsTest, HideShowBrightnessGrayscaleAnimation) {
}
TEST_F(WindowAnimationsTest, LayerTargetVisibility) {
- aura::Window* default_container =
- ash::Shell::GetContainer(
- Shell::GetPrimaryRootWindow(),
- internal::kShellWindowId_DefaultContainer);
scoped_ptr<aura::Window> window(
- aura::test::CreateTestWindowWithId(0, default_container));
+ aura::test::CreateTestWindowWithId(0, NULL));
// Layer target visibility changes according to Show/Hide.
window->Show();
@@ -158,12 +142,8 @@ TEST_F(WindowAnimationsTest, LayerTargetVisibility) {
TEST_F(WindowAnimationsTest, CrossFadeToBounds) {
internal::SetDelayedOldLayerDeletionInCrossFadeForTest(true);
- Window* default_container =
- ash::Shell::GetContainer(
- Shell::GetPrimaryRootWindow(),
- internal::kShellWindowId_DefaultContainer);
scoped_ptr<Window> window(
- aura::test::CreateTestWindowWithId(0, default_container));
+ aura::test::CreateTestWindowWithId(0, NULL));
window->SetBounds(gfx::Rect(5, 10, 320, 240));
window->Show();
« no previous file with comments | « ash/wm/system_modal_container_layout_manager_unittest.cc ('k') | ash/wm/window_cycle_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698