Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 10855266: Don't block CQ usage when includes that violate temporarily-allowed (Closed)

Created:
8 years, 4 months ago by Jói
Modified:
8 years, 4 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Don't block CQ usage when includes that violate temporarily-allowed DEPS rules are added. Includes that violate permant rules are still errors, and on upload there is still a prompt, so the author of the change will definitely know about the problem. BUG=138280 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
I'm finding that at least a third of our refactoring changes for Browser Components need ...
8 years, 4 months ago (2012-08-21 16:41:05 UTC) #1
erikwright (departed)
8 years, 4 months ago (2012-08-21 16:59:06 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698