Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: PRESUBMIT.py

Issue 10855266: Don't block CQ usage when includes that violate temporarily-allowed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 0eefbff4fe0a5ba8fde53071c7961338c184c19e..ac8a719eed171b4c969b46bbf162dff4b28ea556 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -428,7 +428,13 @@ def _CheckUnwantedDependencies(input_api, output_api):
'You added one or more #includes that violate checkdeps rules.',
error_descriptions))
if warning_descriptions:
- results.append(output_api.PresubmitPromptWarning(
+ if not input_api.is_committing:
+ warning_factory = output_api.PresubmitPromptWarning
+ else:
+ # We don't want to block use of the CQ when there is a warning
+ # of this kind, so we only show a message when committing.
+ warning_factory = output_api.PresubmitNotifyResult
+ results.append(warning_factory(
'You added one or more #includes of files that are temporarily\n'
'allowed but being removed. Can you avoid introducing the\n'
'#include? See relevant DEPS file(s) for details and contacts.',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698