Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: build/common.gypi

Issue 10855238: linux/clang: Disable the last two warnings, turn on -Werror (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: cros Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c85107eb74eb9913dbe8b131a10b327d155efc70..7fd9f21b3a6f2d9c06ebb52a66cdf6edb3a6db0b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1618,7 +1618,6 @@
'cflags!': [
'-Wall',
'-Wextra',
- '-Werror',
],
'cflags_cc': [
# Don't warn about hash_map in third-party code.
@@ -1635,6 +1634,12 @@
'-Wsign-compare',
]
}],
+ # TODO: Fix all warnings on chromeos too.
+ [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos==1)', {
+ 'cflags!': [
+ '-Werror',
+ ],
+ }],
[ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', {
'cflags': [
# Don't warn about ignoring the return value from e.g. close().
« no previous file with comments | « breakpad/breakpad.gyp ('k') | net/third_party/nss/ssl.gyp » ('j') | net/third_party/nss/ssl.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698