Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Side by Side Diff: build/common.gypi

Issue 10855238: linux/clang: Disable the last two warnings, turn on -Werror (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: cros Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1600 matching lines...) Expand 10 before | Expand all | Expand 10 after
1611 ], 1611 ],
1612 }], 1612 }],
1613 ['chromium_code==0', { 1613 ['chromium_code==0', {
1614 'conditions': [ 1614 'conditions': [
1615 [ 'os_posix==1 and OS!="mac" and OS!="ios"', { 1615 [ 'os_posix==1 and OS!="mac" and OS!="ios"', {
1616 # We don't want to get warnings from third-party code, 1616 # We don't want to get warnings from third-party code,
1617 # so remove any existing warning-enabling flags like -Wall. 1617 # so remove any existing warning-enabling flags like -Wall.
1618 'cflags!': [ 1618 'cflags!': [
1619 '-Wall', 1619 '-Wall',
1620 '-Wextra', 1620 '-Wextra',
1621 '-Werror',
1622 ], 1621 ],
1623 'cflags_cc': [ 1622 'cflags_cc': [
1624 # Don't warn about hash_map in third-party code. 1623 # Don't warn about hash_map in third-party code.
1625 '-Wno-deprecated', 1624 '-Wno-deprecated',
1626 ], 1625 ],
1627 'cflags': [ 1626 'cflags': [
1628 # Don't warn about printf format problems. 1627 # Don't warn about printf format problems.
1629 # This is off by default in gcc but on in Ubuntu's gcc(!). 1628 # This is off by default in gcc but on in Ubuntu's gcc(!).
1630 '-Wno-format', 1629 '-Wno-format',
1631 ], 1630 ],
1632 'cflags_cc!': [ 1631 'cflags_cc!': [
1633 # TODO(fischman): remove this. 1632 # TODO(fischman): remove this.
1634 # http://code.google.com/p/chromium/issues/detail?id=90453 1633 # http://code.google.com/p/chromium/issues/detail?id=90453
1635 '-Wsign-compare', 1634 '-Wsign-compare',
1636 ] 1635 ]
1637 }], 1636 }],
1637 # TODO: Fix all warnings on chromeos too.
1638 [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos== 1)', {
1639 'cflags!': [
1640 '-Werror',
1641 ],
1642 }],
1638 [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', { 1643 [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', {
1639 'cflags': [ 1644 'cflags': [
1640 # Don't warn about ignoring the return value from e.g. close(). 1645 # Don't warn about ignoring the return value from e.g. close().
1641 # This is off by default in some gccs but on by default in others. 1646 # This is off by default in some gccs but on by default in others.
1642 # BSD systems do not support this option, since they are usually 1647 # BSD systems do not support this option, since they are usually
1643 # using gcc 4.2.1, which does not have this flag yet. 1648 # using gcc 4.2.1, which does not have this flag yet.
1644 '-Wno-unused-result', 1649 '-Wno-unused-result',
1645 ], 1650 ],
1646 }], 1651 }],
1647 [ 'OS=="win"', { 1652 [ 'OS=="win"', {
(...skipping 1735 matching lines...) Expand 10 before | Expand all | Expand 10 after
3383 # settings in target dicts. SYMROOT is a special case, because many other 3388 # settings in target dicts. SYMROOT is a special case, because many other
3384 # Xcode variables depend on it, including variables such as 3389 # Xcode variables depend on it, including variables such as
3385 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3390 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3386 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3391 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3387 # files to appear (when present) in the UI as actual files and not red 3392 # files to appear (when present) in the UI as actual files and not red
3388 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3393 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3389 # and therefore SYMROOT, needs to be set at the project level. 3394 # and therefore SYMROOT, needs to be set at the project level.
3390 'SYMROOT': '<(DEPTH)/xcodebuild', 3395 'SYMROOT': '<(DEPTH)/xcodebuild',
3391 }, 3396 },
3392 } 3397 }
OLDNEW
« no previous file with comments | « breakpad/breakpad.gyp ('k') | net/third_party/nss/ssl.gyp » ('j') | net/third_party/nss/ssl.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698