Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 10855237: Unrevert 152017 - Add chrome.runtime.onStartup, which is fired on browser start. (Closed)

Created:
8 years, 4 months ago by Matt Perry
Modified:
8 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Unrevert 152017 - Add chrome.runtime.onStartup, which is fired on browser start. I reused LazyBackgroundTaskQueue so that this works for regular background pages, which may not be fully loaded by the time this event is dispatched. BUG=132328 Review URL: https://chromiumcodereview.appspot.com/10828218 Reason for revert: introduced a frequent crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152238

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -27 lines) Patch
M chrome/browser/extensions/api/runtime/runtime_api.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 chunk +48 lines, -1 line 1 comment Download
M chrome/browser/extensions/event_router.cc View 5 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 4 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/common/extensions/api/runtime.json View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/apps/runtime.html View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/runtime.html View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
http://codereview.chromium.org/10855237/diff/1/chrome/browser/extensions/api/runtime/runtime_api.cc File chrome/browser/extensions/api/runtime/runtime_api.cc (right): http://codereview.chromium.org/10855237/diff/1/chrome/browser/extensions/api/runtime/runtime_api.cc#newcode36 chrome/browser/extensions/api/runtime/runtime_api.cc:36: return; This should fix the crash. We were crashing ...
8 years, 4 months ago (2012-08-17 23:37:30 UTC) #1
Yoyo Zhou
LGTM
8 years, 4 months ago (2012-08-18 00:02:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10855237/1
8 years, 4 months ago (2012-08-18 00:51:38 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-18 04:10:07 UTC) #4
Change committed as 152238

Powered by Google App Engine
This is Rietveld 408576698