chrome/browser/extensions/api/tabs/tabs.cc - Issue 10855225: Restore panel behavior on Ash/ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 10855225: Restore panel behavior on Ash/ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc

index 99d87491b30d6b2c735e7b617a2d8c0e09bc6b2e..ae4637dfb54fc989187240c1c0b6abed802929d5 100644

--- a/chrome/browser/extensions/api/tabs/tabs.cc

+++ b/chrome/browser/extensions/api/tabs/tabs.cc

@@ -557,7 +557,7 @@ bool CreateWindowFunction::RunImpl() {

} else if (type_str == keys::kWindowTypeValuePanel) {

extension_id = GetExtension()->id();

bool use_panels = false;

-#if !defined(OS_ANDROID) && !defined(USE_ASH)

+#if !defined(OS_ANDROID)

use_panels = PanelManager::ShouldUsePanels(extension_id);

#endif

if (use_panels)

« no previous file with comments | « no previous file | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »