Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 10855225: Restore panel behavior on Ash/ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.cc ('k') | chrome/browser/ui/views/frame/browser_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/window_open_apitest.cc
diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc
index 5283e55c61e209f4ffbc7e2d53f3e953be1d16cb..51edeaf45c1431243aba677aa2f12172db49a4a6 100644
--- a/chrome/browser/extensions/window_open_apitest.cc
+++ b/chrome/browser/extensions/window_open_apitest.cc
@@ -220,13 +220,8 @@ IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest,
CloseNonExtensionPanelsOnUninstall) {
if (!PanelManager::UseBrowserlessPanels())
return;
-#if defined(USE_ASH)
- int num_popups = 4;
- int num_panels = 0;
-#else
int num_popups = 2;
int num_panels = 2;
-#endif
ASSERT_TRUE(StartTestServer());
// Setup listeners to wait on strings we expect the extension pages to send.
@@ -260,12 +255,7 @@ IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest,
// Wait for one tab and one popup in non-extension domain to stay open.
// Expect everything else, including panels, to close.
-#if defined(USE_ASH)
- // In Ash and additional popup remains for the "panel" non-extension domain.
- num_popups = 2;
-#else
num_popups = 1;
-#endif
WaitForTabsAndPopups(browser(), 1, num_popups, 0);
}
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.cc ('k') | chrome/browser/ui/views/frame/browser_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698