Restore panel behavior on Ash/ChromeOS

Restore panel behavior on Ash/ChromeOS

When we abandoned support for Ash Panels for v1 apps (--aura-panels flag), I inadvertently disabled the check that enables panels for Quasar.
The special panel behavior includes:
* Panels are treated like popup windows but are always-on-top
* Panel icons in the launcher use a large favicon by itself (instead of the default favicon framed in a rounded rectangle)

BUG=141763
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152460

[stevenjb, 2012-08-17 17:48:00]

Zel, please confirm that we want to restore both the special launcher icons, and
the always-on-top behavior for Quasar panels on ChromeOS.

[Mihai Parparita -not on Chrome, 2012-08-17 17:56:28]

OWNERS LGTM

Mihai

On Fri, Aug 17, 2012 at 10:48 AM, <stevenjb@chromium.org> wrote:

> Reviewers: zel, Mihai Parparita,
>
> Message:
> Zel, please confirm that we want to restore both the special launcher
> icons, and
> the always-on-top behavior for Quasar panels on ChromeOS.
>
>
> Description:
> Restore panel behavior on Ash/ChromeOS
>
> When we abandoned support for Ash Panels for v1 apps (--aura-panels flag),
> I
> inadvertently disabled the check that enables panels for Quasar.
> The special panel behavior includes:
> * Panels are treated like popup windows but are always-on-top
> * Panel icons in the launcher use a large favicon by itself (instead of the
> default favicon framed in a rounded rectangle)
>
> BUG=141763
>
>
> Please review this at
http://codereview.chromium.**org/10855225/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/extensions/api/**tabs/tabs.cc
>
>
> Index: chrome/browser/extensions/api/**tabs/tabs.cc
> diff --git a/chrome/browser/extensions/**api/tabs/tabs.cc
> b/chrome/browser/extensions/**api/tabs/tabs.cc
> index 2e069b65cb5a57a4be5c3006c08678**5fe7444e8b..**
> 97a692284dbe35b4ddfb7314b6a0a0**aa832980d4 100644
> --- a/chrome/browser/extensions/**api/tabs/tabs.cc
> +++ b/chrome/browser/extensions/**api/tabs/tabs.cc
> @@ -557,7 +557,7 @@ bool CreateWindowFunction::RunImpl(**) {
>        } else if (type_str == keys::kWindowTypeValuePanel) {
>          extension_id = GetExtension()->id();
>          bool use_panels = false;
> -#if !defined(OS_ANDROID) && !defined(USE_ASH)
> +#if !defined(OS_ANDROID)
>          use_panels = PanelManager::ShouldUsePanels(**extension_id);
>  #endif
>          if (use_panels)
>
>
>

[zel, 2012-08-17 19:00:12]

On 2012/08/17 17:56:28, Mihai Parparita wrote:
> OWNERS LGTM
> 
> Mihai
> 
> On Fri, Aug 17, 2012 at 10:48 AM, <mailto:stevenjb@chromium.org> wrote:
> 
> > Reviewers: zel, Mihai Parparita,
> >
> > Message:
> > Zel, please confirm that we want to restore both the special launcher
> > icons, and
> > the always-on-top behavior for Quasar panels on ChromeOS.
> >
> >
> > Description:
> > Restore panel behavior on Ash/ChromeOS
> >
> > When we abandoned support for Ash Panels for v1 apps (--aura-panels flag),
> > I
> > inadvertently disabled the check that enables panels for Quasar.
> > The special panel behavior includes:
> > * Panels are treated like popup windows but are always-on-top
> > * Panel icons in the launcher use a large favicon by itself (instead of the
> > default favicon framed in a rounded rectangle)
> >
> > BUG=141763
> >
> >
> > Please review this at
>
http://codereview.chromium.**org/10855225/%3Chttp://codereview.chromium.org/1...>
> >
> > SVN Base:
>
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
> >
> > Affected files:
> >   M chrome/browser/extensions/api/**tabs/tabs.cc
> >
> >
> > Index: chrome/browser/extensions/api/**tabs/tabs.cc
> > diff --git a/chrome/browser/extensions/**api/tabs/tabs.cc
> > b/chrome/browser/extensions/**api/tabs/tabs.cc
> > index 2e069b65cb5a57a4be5c3006c08678**5fe7444e8b..**
> > 97a692284dbe35b4ddfb7314b6a0a0**aa832980d4 100644
> > --- a/chrome/browser/extensions/**api/tabs/tabs.cc
> > +++ b/chrome/browser/extensions/**api/tabs/tabs.cc
> > @@ -557,7 +557,7 @@ bool CreateWindowFunction::RunImpl(**) {
> >        } else if (type_str == keys::kWindowTypeValuePanel) {
> >          extension_id = GetExtension()->id();
> >          bool use_panels = false;
> > -#if !defined(OS_ANDROID) && !defined(USE_ASH)
> > +#if !defined(OS_ANDROID)
> >          use_panels = PanelManager::ShouldUsePanels(**extension_id);
> >  #endif
> >          if (use_panels)
> >
> >
> >

Why are those always-on-top?

[stevenjb, 2012-08-17 19:20:06]

That was the behavior we decided on when we first switched to aura/ash. That is
the current behavior in R21. If we want to remove the always-on-top property we
certainly can, but we should confirm that with the UX team.

[stevenjb, 2012-08-17 19:23:19]

The original issue where we set panels to be always on top:
http://code.google.com/p/chromium/issues/detail?id=119794

[stevenjb, 2012-08-17 20:03:23]

Added change to remove always-on-top behavior for browser panels in Ash.
+ben for change to browser_frame.cc

[zel, 2012-08-17 21:03:47]

lgtm

[Ben Goodger (Google), 2012-08-20 20:10:37]

lgtm

[commit-bot: I haz the power, 2012-08-20 20:21:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10855225/3004

[commit-bot: I haz the power, 2012-08-20 20:21:45]

Failed to apply patch for chrome/browser/extensions/window_open_apitest.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/window_open_apitest.cc
Hunk #1 FAILED at 216.
Hunk #2 succeeded at 260 (offset 4 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/extensions/window_open_apitest.cc.rej

[commit-bot: I haz the power, 2012-08-20 23:38:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10855225/1003

[commit-bot: I haz the power, 2012-08-21 01:06:22]

Change committed as 152460