Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6359)

Unified Diff: chrome/browser/printing/print_dialog_cloud_interative_uitest.cc

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest merge Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_dialog_cloud_interative_uitest.cc
diff --git a/chrome/browser/printing/print_dialog_cloud_interative_uitest.cc b/chrome/browser/printing/print_dialog_cloud_interative_uitest.cc
index cb71eaac6966997e2fc35d7931196ea56a613822..fabc49ef01e59661da3cbe59e48e09c2cc66856e 100644
--- a/chrome/browser/printing/print_dialog_cloud_interative_uitest.cc
+++ b/chrome/browser/printing/print_dialog_cloud_interative_uitest.cc
@@ -29,6 +29,7 @@
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/test_browser_thread.h"
+#include "net/url_request/url_request.h"
#include "net/url_request/url_request_filter.h"
#include "net/url_request/url_request_test_job.h"
#include "net/url_request/url_request_test_util.h"
@@ -70,9 +71,13 @@ class TestData {
// whether it starts and finishes.
class SimpleTestJob : public net::URLRequestTestJob {
public:
- explicit SimpleTestJob(net::URLRequest* request)
- : net::URLRequestTestJob(request, test_headers(),
- TestData::GetInstance()->GetTestData(), true) {}
+ SimpleTestJob(net::URLRequest* request,
+ net::NetworkDelegate* network_delegate)
+ : net::URLRequestTestJob(request,
+ network_delegate,
+ test_headers(),
+ TestData::GetInstance()->GetTestData(),
+ true) {}
virtual void GetResponseInfo(net::HttpResponseInfo* info) {
net::URLRequestTestJob::GetResponseInfo(info);
@@ -220,18 +225,22 @@ class PrintDialogCloudTest : public InProcessBrowserTest {
AutoQuitDelegate delegate_;
};
-net::URLRequestJob* PrintDialogCloudTest::Factory(net::URLRequest* request,
- const std::string& scheme) {
+net::URLRequestJob* PrintDialogCloudTest::Factory(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate,
+ const std::string& scheme) {
if (request &&
(request->url() == TestController::GetInstance()->expected_url())) {
if (TestController::GetInstance()->use_delegate())
request->set_delegate(TestController::GetInstance()->delegate());
TestController::GetInstance()->set_result(true);
- return new SimpleTestJob(request);
+ return new SimpleTestJob(request, network_delegate);
}
return new net::URLRequestTestJob(request,
+ network_delegate,
net::URLRequestTestJob::test_headers(),
- "", true);
+ "",
+ true);
}
#if defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698