Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10855186: Fix grammar on off-store install error. (Closed)

Created:
8 years, 4 months ago by Aaron Boodman
Modified:
8 years, 4 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix grammar on off-store install error. BUG=139773 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151834

Patch Set 1 #

Total comments: 1

Patch Set 2 : website is one word #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Aaron Boodman
8 years, 4 months ago (2012-08-15 23:16:52 UTC) #1
Jeffrey Yasskin
LGTM. https://chromiumcodereview.appspot.com/10855186/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/10855186/diff/1/chrome/app/generated_resources.grd#newcode4580 chrome/app/generated_resources.grd:4580: + Apps, extensions, and user scripts cannot be ...
8 years, 4 months ago (2012-08-15 23:55:25 UTC) #2
Aaron Boodman
On 2012/08/15 23:55:25, Jeffrey Yasskin wrote: > LGTM. > > https://chromiumcodereview.appspot.com/10855186/diff/1/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): ...
8 years, 4 months ago (2012-08-16 00:09:58 UTC) #3
Aaron Boodman
8 years, 4 months ago (2012-08-16 00:16:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10855186/1002
8 years, 4 months ago (2012-08-16 00:17:20 UTC) #5
commit-bot: I haz the power
Change committed as 151834
8 years, 4 months ago (2012-08-16 02:37:57 UTC) #6
Jeffrey Yasskin
8 years, 4 months ago (2012-08-16 18:27:01 UTC) #7
On Wed, Aug 15, 2012 at 5:09 PM,  <aa@chromium.org> wrote:
> What do you mean the meaning changed?

Before it said, "there is only one place to install stuff." Now it
says, "there's at least one place you can't install stuff." The new
meaning is more correct, since you can drag files into the extensions
page and use corporate policies to enable more sites.

Powered by Google App Engine
This is Rietveld 408576698