Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 10855137: [WebIntents] Cleanup of unused functions/default implementations (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16
Modified:
8 years, 4 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org
Visibility:
Public.

Description

[WebIntents] Cleanup of unused functions/default implementations R=jhawkins@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151638

Patch Set 1 #

Patch Set 2 : Fix unit tests. #

Patch Set 3 : Fix browser tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.h View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
groby-ooo-7-16
8 years, 4 months ago (2012-08-14 01:02:00 UTC) #1
James Hawkins
lgtm
8 years, 4 months ago (2012-08-14 01:02:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10855137/1
8 years, 4 months ago (2012-08-14 01:06:06 UTC) #3
commit-bot: I haz the power
Try job failure for 10855137-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-14 01:41:02 UTC) #4
groby-ooo-7-16
Heads up - fixed missing implementations for tests. Committing.
8 years, 4 months ago (2012-08-14 21:27:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10855137/6003
8 years, 4 months ago (2012-08-14 21:30:05 UTC) #6
commit-bot: I haz the power
Try job failure for 10855137-6003 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-14 23:07:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10855137/6003
8 years, 4 months ago (2012-08-14 23:52:07 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 02:38:01 UTC) #9
Change committed as 151638

Powered by Google App Engine
This is Rietveld 408576698