Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7853)

Unified Diff: chrome/browser/ui/intents/web_intent_picker.h

Issue 10855137: [WebIntents] Cleanup of unused functions/default implementations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix browser tests Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker.h
diff --git a/chrome/browser/ui/intents/web_intent_picker.h b/chrome/browser/ui/intents/web_intent_picker.h
index cc088e5cf8522a6bd57a0e652783d6fb3438c15a..d65c9419212385e39582ddab3098218ad6a27270 100644
--- a/chrome/browser/ui/intents/web_intent_picker.h
+++ b/chrome/browser/ui/intents/web_intent_picker.h
@@ -37,26 +37,22 @@ class WebIntentPicker {
virtual void SetActionString(const string16& action) = 0;
// Called when an extension is successfully installed via the picker.
- virtual void OnExtensionInstallSuccess(const std::string& id) {}
+ virtual void OnExtensionInstallSuccess(const std::string& id) = 0;
// Called when an extension installation started via the picker has failed.
- virtual void OnExtensionInstallFailure(const std::string& id) {}
+ virtual void OnExtensionInstallFailure(const std::string& id) = 0;
// Called when the inline disposition experiences an auto-resize.
- virtual void OnInlineDispositionAutoResize(const gfx::Size& size) {}
+ virtual void OnInlineDispositionAutoResize(const gfx::Size& size) = 0;
// Called when the controller has finished all pending asynchronous
// activities.
- virtual void OnPendingAsyncCompleted() {}
+ virtual void OnPendingAsyncCompleted() = 0;
// Called when the inline disposition's web contents have been loaded.
virtual void OnInlineDispositionWebContentsLoaded(
content::WebContents* web_contents) {}
- // Get the default size of the inline disposition tab container.
- static gfx::Size GetDefaultInlineDispositionSize(
- content::WebContents* web_contents);
-
// Get the minimum size of the inline disposition content container.
static gfx::Size GetMinInlineDispositionSize();

Powered by Google App Engine
This is Rietveld 408576698