Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10855125: Ensure supertypes are loaded safely. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Ensure supertypes are loaded safely. Committed: https://code.google.com/p/dart/source/detail?r=10586

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Rebased #

Patch Set 3 : Address review comments. #

Patch Set 4 : Fix bad merge #

Patch Set 5 : Cleanup ClassElement.cloneMembersTo. #

Patch Set 6 : Rebased #

Patch Set 7 : More cleanup of ClassElement.cloneMembersTo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -155 lines) Patch
M dart/lib/compiler/implementation/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/compiler.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M dart/lib/compiler/implementation/elements/elements.dart View 1 2 3 4 5 6 6 chunks +29 lines, -40 lines 2 comments Download
M dart/lib/compiler/implementation/enqueue.dart View 1 chunk +1 line, -3 lines 0 comments Download
M dart/lib/compiler/implementation/resolver.dart View 1 2 3 4 16 chunks +159 lines, -71 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/class_element_parser.dart View 1 2 3 4 5 6 1 chunk +22 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/closure.dart View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/typechecker.dart View 2 chunks +11 lines, -4 lines 0 comments Download
M dart/lib/compiler/implementation/world.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/co19/co19-leg.status View 1 2 3 4 5 6 chunks +41 lines, -19 lines 0 comments Download
M dart/tests/compiler/dart2js/mock_compiler.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js/resolver_test.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
8 years, 4 months ago (2012-08-13 13:20:08 UTC) #1
Lasse Reichstein Nielsen
LGTM https://chromiumcodereview.appspot.com/10855125/diff/3015/dart/lib/compiler/implementation/elements/elements.dart File dart/lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10855125/diff/3015/dart/lib/compiler/implementation/elements/elements.dart#newcode452 dart/lib/compiler/implementation/elements/elements.dart:452: cachedType.initializeFrom( Make initialize a copy constructor instead. https://chromiumcodereview.appspot.com/10855125/diff/3015/dart/lib/compiler/implementation/elements/elements.dart#newcode901 ...
8 years, 4 months ago (2012-08-13 13:34:48 UTC) #2
ahe
Thank you, Lasse! Cheers, Peter https://chromiumcodereview.appspot.com/10855125/diff/3015/dart/lib/compiler/implementation/elements/elements.dart File dart/lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10855125/diff/3015/dart/lib/compiler/implementation/elements/elements.dart#newcode452 dart/lib/compiler/implementation/elements/elements.dart:452: cachedType.initializeFrom( On 2012/08/13 13:34:48, ...
8 years, 4 months ago (2012-08-13 15:14:01 UTC) #3
ahe
Hi Lasse, I had to make some changes to cloneMembersTo. Please take another look at ...
8 years, 4 months ago (2012-08-13 16:44:12 UTC) #4
Lasse Reichstein Nielsen
https://chromiumcodereview.appspot.com/10855125/diff/10035/dart/lib/compiler/implementation/elements/elements.dart File dart/lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10855125/diff/10035/dart/lib/compiler/implementation/elements/elements.dart#newcode1003 dart/lib/compiler/implementation/elements/elements.dart:1003: } I'd prefer putting getters/setters after the constructor, so ...
8 years, 4 months ago (2012-08-14 08:40:36 UTC) #5
ahe
8 years, 4 months ago (2012-08-14 11:10:42 UTC) #6 
Thank you, Lasse!

https://chromiumcodereview.appspot.com/10855125/diff/10035/dart/lib/compiler/...
File dart/lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10855125/diff/10035/dart/lib/compiler/...
dart/lib/compiler/implementation/elements/elements.dart:1003: }
On 2012/08/14 08:40:36, Lasse Reichstein Nielsen wrote:
> I'd prefer putting getters/setters after the constructor, so constructors are
> the first code in the class.

Agreed. In addition, I don't like Dart's privacy. I feel I have cleaned it up in
https://chromiumcodereview.appspot.com/10823311/.

Powered by Google App Engine
This is Rietveld 408576698