dart/lib/compiler/implementation/ssa/builder.dart - Issue 10855125: Ensure supertypes are loaded safely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/compiler/implementation/ssa/builder.dart

Issue 10855125: Ensure supertypes are loaded safely. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: More cleanup of ClassElement.cloneMembersTo Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/lib/compiler/implementation/ssa/builder.dart

diff --git a/dart/lib/compiler/implementation/ssa/builder.dart b/dart/lib/compiler/implementation/ssa/builder.dart

index 941cbbb59f6e0a97536267ef8efdb9173040c870..e32848f3dfb0c82ec2c03c4d2592b04f94ecb2ad 100644

--- a/dart/lib/compiler/implementation/ssa/builder.dart

+++ b/dart/lib/compiler/implementation/ssa/builder.dart

@@ -988,7 +988,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

ClassElement superClass = enclosingClass.superclass;

if (enclosingClass != compiler.objectClass) {

assert(superClass !== null);

- assert(superClass.isResolved);

+ assert(superClass.resolutionState == ClassElement.STATE_DONE);

FunctionElement target = superClass.lookupConstructor(superClass.name);

if (target === null) {

compiler.internalError("no default constructor available");