Clean-up inline members of nested classes (remoting/)

Clean-up inline members of nested classes (remoting/)

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150913

[Wez, 2012-08-09 19:58:03]

I think it makes more sense to have SignalStrategy::Listener be a pure virtual
interface, and add the necessary overrides of OnSignalStrategyIncomingStanza to
LogToServer and ConnectionToHost, rather than add another cc file just for the
base implementation.

sergeyu@: Any strong opinion either way?

[Sergey Ulanov, 2012-08-09 20:10:07]

On 2012/08/09 19:58:03, Wez wrote:
> I think it makes more sense to have SignalStrategy::Listener be a pure virtual
> interface, and add the necessary overrides of OnSignalStrategyIncomingStanza
to
> LogToServer and ConnectionToHost, rather than add another cc file just for the
> base implementation.
> 
> sergeyu@: Any strong opinion either way?

No, but I agree that making Listener interface pure virtual would be slightly
cleaner.

[hans, 2012-08-09 20:41:13]

On 2012/08/09 20:10:07, sergeyu wrote:
> On 2012/08/09 19:58:03, Wez wrote:
> > I think it makes more sense to have SignalStrategy::Listener be a pure
virtual
> > interface, and add the necessary overrides of OnSignalStrategyIncomingStanza
> to
> > LogToServer and ConnectionToHost, rather than add another cc file just for
the
> > base implementation.

OK. New patch uploaded. Please take a look.

[Sergey Ulanov, 2012-08-09 20:47:20]

LGTM. Thanks!

On 2012/08/09 20:41:13, hans wrote:
> On 2012/08/09 20:10:07, sergeyu wrote:
> > On 2012/08/09 19:58:03, Wez wrote:
> > > I think it makes more sense to have SignalStrategy::Listener be a pure
> virtual
> > > interface, and add the necessary overrides of
OnSignalStrategyIncomingStanza
> > to
> > > LogToServer and ConnectionToHost, rather than add another cc file just for
> the
> > > base implementation.
> 
> OK. New patch uploaded. Please take a look.

[commit-bot: I haz the power, 2012-08-09 20:49:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/10855076/7001

[commit-bot: I haz the power, 2012-08-09 22:18:22]

Change committed as 150913