Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10855075: Clean-up inline members of nested classes (chrome/) (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jennb, marja+watch_chromium.org, yoshiki+watch_chromium.org, Dmitry Titov, dcheng, Aaron Boodman, rginda+watch_chromium.org, Satish, darin-cc_chromium.org, jianli, rdsmith+dwatch_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Clean-up inline members of nested classes (chrome/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -95 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/download/download_request_limiter.h View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/user_script_master.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/file_select_helper.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/file_select_helper.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/gpu_blacklist.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu_blacklist.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/process_info_snapshot.h View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/process_info_snapshot_mac.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sessions/base_session_service.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 3 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.h View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.h View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_set.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_set.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_authenticator.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_authenticator.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/test/base/menu_model_test.h View 1 chunk +4 lines, -9 lines 0 comments Download
M chrome/test/base/menu_model_test.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
8 years, 4 months ago (2012-08-09 13:48:51 UTC) #1
Nico
lgtm
8 years, 4 months ago (2012-08-10 15:36:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10855075/1
8 years, 4 months ago (2012-08-10 19:47:07 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 22:08:10 UTC) #4
Change committed as 151135

Powered by Google App Engine
This is Rietveld 408576698