Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8930)

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher.h

Issue 10855075: Clean-up inline members of nested classes (chrome/) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/gaia/gaia_authenticator.cc ('k') | chrome/service/cloud_print/cloud_print_url_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/cloud_print/cloud_print_url_fetcher.h
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.h b/chrome/service/cloud_print/cloud_print_url_fetcher.h
index 77bf8f68724fd457a60d600b5192e3c1d989b7ac..d976f7120911f76332743318332dbf353f20bf20 100644
--- a/chrome/service/cloud_print/cloud_print_url_fetcher.h
+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.h
@@ -50,9 +50,8 @@ class CloudPrintURLFetcher
const net::URLRequestStatus& status,
int response_code,
const net::ResponseCookies& cookies,
- const std::string& data) {
- return CONTINUE_PROCESSING;
- }
+ const std::string& data);
+
// This will be invoked only if HandleRawResponse returns
// CONTINUE_PROCESSING AND if there are no network errors and the HTTP
// response code is 200. The delegate implementation returns
@@ -62,21 +61,20 @@ class CloudPrintURLFetcher
// response).
virtual ResponseAction HandleRawData(const net::URLFetcher* source,
const GURL& url,
- const std::string& data) {
- return CONTINUE_PROCESSING;
- }
+ const std::string& data);
+
// This will be invoked only if HandleRawResponse and HandleRawData return
// CONTINUE_PROCESSING AND if the response contains a valid JSON dictionary.
// |succeeded| is the value of the "success" field in the response JSON.
virtual ResponseAction HandleJSONData(const net::URLFetcher* source,
const GURL& url,
base::DictionaryValue* json_data,
- bool succeeded) {
- return CONTINUE_PROCESSING;
- }
+ bool succeeded);
+
// Invoked when the retry limit for this request has been reached (if there
// was a retry limit - a limit of -1 implies no limit).
virtual void OnRequestGiveUp() { }
+
// Invoked when the request returns a 403 error (applicable only when
// HandleRawResponse returns CONTINUE_PROCESSING).
// Returning RETRY_REQUEST will retry current request. (auth information
« no previous file with comments | « chrome/common/net/gaia/gaia_authenticator.cc ('k') | chrome/service/cloud_print/cloud_print_url_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698