Issue 10855040: Reverting r1457, r1452, r1450, r1449.

Issue 10855040: Reverting r1457, r1452, r1450, r1449. (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)

Modified:
7 years, 5 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com, jianli

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixed "RC4011: identifier truncated" warning when embedding manifests. Including <winuser.h> directly caused the following warning on VS2010: string.h(54) : warning RC4011: identifier truncated to '_CRT_SECURE_CPP_OVERLOAD_STANDA'

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -150 lines)			Patch
M	pylib/gyp/generator/msvs.py	View	4 chunks	+0 lines, -6 lines	0 comments	Download
M	pylib/gyp/generator/ninja.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pylib/gyp/win_tool.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	test/win/gyptest-midl-additional-include-dirs.py	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	test/win/gyptest-midl-basic.py	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	test/win/gyptest-midl-defines.py	View	1 chunk	+0 lines, -22 lines	0 comments	Download
A +	test/win/gyptest-midl-rules.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	test/win/idl-rules/additional-include-dirs.gyp	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	test/win/idl-rules/additional-include-dirs.idl	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	test/win/idl-rules/defines.gyp	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	test/win/idl-rules/defines.idl	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	test/win/idl-rules/include/additional-include.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

On 2012/08/08 00:35:10, alexeypa wrote: > PTAL. BTW this is a clean revert.

8 years, 4 months ago (2012-08-08 00:35:34 UTC) #2

scottmg

On 2012/08/08 00:35:34, alexeypa wrote: > On 2012/08/08 00:35:10, alexeypa wrote: > > PTAL. > ...

8 years, 4 months ago (2012-08-08 02:09:06 UTC) #3

ukai

8 years, 4 months ago (2012-08-08 02:14:40 UTC) #4

On 2012/08/08 02:09:06, scottmg wrote:
> On 2012/08/08 00:35:34, alexeypa wrote:
> > On 2012/08/08 00:35:10, alexeypa wrote:
> > > PTAL.
> > 
> > BTW this is a clean revert.
> 
> lgtm
> 
> Hopefully we'll have ninja bots on Chromium soon to avoid this churn.

You can watch it
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20Ninja%20Goma/

Expand Messages | Collapse Messages