Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: pylib/gyp/win_tool.py

Issue 10855040: Reverting r1457, r1452, r1450, r1449. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/win/gyptest-midl-additional-include-dirs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/win_tool.py
===================================================================
--- pylib/gyp/win_tool.py (revision 1457)
+++ pylib/gyp/win_tool.py (working copy)
@@ -104,7 +104,7 @@
'/proxy', proxy,
idl]
env = self._GetEnv(arch)
- popen = subprocess.Popen(args, shell=False, env=env,
+ popen = subprocess.Popen(args, shell=True, env=env,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
out, _ = popen.communicate()
# Filter junk out of stdout, and write filtered versions. Output we want
@@ -125,7 +125,7 @@
# MSVS doesn't assemble x64 asm files.
if arch == 'environment.x64':
return 0
- popen = subprocess.Popen(args, shell=False, env=env,
+ popen = subprocess.Popen(args, shell=True, env=env,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
out, _ = popen.communicate()
for line in out.splitlines():
@@ -140,7 +140,7 @@
"""Filter logo banner from invocations of rc.exe. Older versions of RC
don't support the /nologo flag."""
env = self._GetEnv(arch)
- popen = subprocess.Popen(args, shell=False, env=env,
+ popen = subprocess.Popen(args, shell=True, env=env,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
out, _ = popen.communicate()
for line in out.splitlines():
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/win/gyptest-midl-additional-include-dirs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698