Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed)

Created:
8 years, 4 months ago by Haruki Sato
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, kkania, erikwright (departed), achuith+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, grt+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, to remove static_cast<> in the callers. BUG=139130 TEST=try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151192

Patch Set 1 : #

Total comments: 51

Patch Set 2 : Comments and Styles Fixes. #

Patch Set 3 : Addressed the comments about constant names. #

Total comments: 12

Patch Set 4 : style fixes #

Patch Set 5 : rebase #

Patch Set 6 : fix missing comma. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -143 lines) Patch
M base/file_util.h View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M base/file_util.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/file_util_posix.cc View 1 2 3 4 chunks +7 lines, -10 lines 0 comments Download
M base/file_util_unittest.cc View 1 2 3 4 5 3 chunks +6 lines, -11 lines 0 comments Download
M base/file_util_win.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/test_file_util_posix.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache.cc View 1 2 3 4 5 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache_metadata.cc View 1 2 3 4 5 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache_unittest.cc View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/camera_detector.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/policy/app_pack_updater.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/common/zip.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/common/zip_unittest.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/installer/util/duplicate_tree_detector.cc View 1 2 3 4 5 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/test/webdriver/webdriver_util.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_message_filter.cc View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download
M net/base/directory_lister.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/cache_util_posix.cc View 1 2 3 1 chunk +3 lines, -6 lines 0 comments Download
M webkit/fileapi/file_system_database_test_helper.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M webkit/fileapi/file_system_directory_database.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M webkit/fileapi/isolated_file_util_unittest.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M webkit/fileapi/local_file_util.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M webkit/fileapi/native_file_util.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
Haruki Sato
Main changes are in file_util* files and each of the caller files has a few ...
8 years, 4 months ago (2012-08-06 04:28:27 UTC) #1
Haruki Sato
Added several more reviewers. Brett, could you take a look at this as an OWNER ...
8 years, 4 months ago (2012-08-06 04:47:14 UTC) #2
not at google - send to devlin
extensions lgtm (those kFooBar changes were already like that, so I don't really mind if ...
8 years, 4 months ago (2012-08-06 05:04:56 UTC) #3
kochi
lgtm
8 years, 4 months ago (2012-08-06 05:35:25 UTC) #4
satorux1
LGTM with a suggestion: http://codereview.chromium.org/10855002/diff/32/base/file_util.h File base/file_util.h (right): http://codereview.chromium.org/10855002/diff/32/base/file_util.h#newcode520 base/file_util.h:520: // |file_type| specifies whether the ...
8 years, 4 months ago (2012-08-06 06:09:01 UTC) #5
Mattias Nissler (ping if slow)
LGTM for chrome/browser/policy
8 years, 4 months ago (2012-08-06 07:29:33 UTC) #6
jar (doing other things)
Only provided readability nits. Generally, you don't need extra parens around an argument, and there ...
8 years, 4 months ago (2012-08-06 18:27:01 UTC) #7
Haruki Sato
Thank you for the quick review! jar, I tried to push as many args to ...
8 years, 4 months ago (2012-08-06 23:22:17 UTC) #8
not at google - send to devlin
http://codereview.chromium.org/10855002/diff/32/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc File chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc (right): http://codereview.chromium.org/10855002/diff/32/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc#newcode69 chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc:69: const int FILES_AND_SYM_LINKS = On 2012/08/06 23:22:18, Haruki Sato ...
8 years, 4 months ago (2012-08-06 23:28:18 UTC) #9
jar (doing other things)
LGTM for base. See nit below. http://codereview.chromium.org/10855002/diff/32/chrome/browser/chromeos/gdata/gdata_cache.cc File chrome/browser/chromeos/gdata/gdata_cache.cc (right): http://codereview.chromium.org/10855002/diff/32/chrome/browser/chromeos/gdata/gdata_cache.cc#newcode186 chrome/browser/chromeos/gdata/gdata_cache.cc:186: file_util::FileEnumerator::SHOW_SYM_LINKS), These examples ...
8 years, 4 months ago (2012-08-07 01:47:43 UTC) #10
Haruki Sato
http://codereview.chromium.org/10855002/diff/32/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc File chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc (right): http://codereview.chromium.org/10855002/diff/32/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc#newcode69 chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc:69: const int FILES_AND_SYM_LINKS = On 2012/08/07 01:47:43, jar wrote: ...
8 years, 4 months ago (2012-08-07 02:29:17 UTC) #11
not at google - send to devlin
lgtm
8 years, 4 months ago (2012-08-07 02:43:00 UTC) #12
not at google - send to devlin
(for extensions, in response to your comment about checking it again)
8 years, 4 months ago (2012-08-07 02:43:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10855002/3008
8 years, 4 months ago (2012-08-07 03:42:52 UTC) #14
commit-bot: I haz the power
Presubmit check for 10855002-3008 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-07 03:43:02 UTC) #15
Haruki Sato
Adding several more reviewers for OWNERS reviews for the directories. ben@ for content/browser/renderer_host kkania@ for ...
8 years, 4 months ago (2012-08-07 04:38:21 UTC) #16
kinuko
webkit/fileapi lgtm On 2012/08/07 04:38:21, Haruki Sato wrote: > Adding several more reviewers for OWNERS ...
8 years, 4 months ago (2012-08-07 05:22:46 UTC) #17
kinuko
some nits. (still lgtm) http://codereview.chromium.org/10855002/diff/3008/base/file_util.h File base/file_util.h (right): http://codereview.chromium.org/10855002/diff/3008/base/file_util.h#newcode520 base/file_util.h:520: // |file_type|, a bit mask ...
8 years, 4 months ago (2012-08-07 05:23:11 UTC) #18
Haruki Sato
I now understand no-parentheses is our style here. Revised those styles. Thank you jar, kalman, ...
8 years, 4 months ago (2012-08-07 13:34:25 UTC) #19
ericu
webkit/fileapi LGTM
8 years, 4 months ago (2012-08-07 16:34:19 UTC) #20
Ben Goodger (Google)
Pepper-related, so replacing myself with Brett who can review the content/browser/renderer_host or delegate.
8 years, 4 months ago (2012-08-07 18:07:05 UTC) #21
Haruki Sato
Thank you all for the review! brettw@, grt@, could you take a look? Thanks.
8 years, 4 months ago (2012-08-08 08:16:45 UTC) #22
Haruki Sato
Seems to me I've already got OWNERS's lgtm covering whole my change. Posting to CQ. ...
8 years, 4 months ago (2012-08-09 09:00:23 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10855002/6010
8 years, 4 months ago (2012-08-09 09:00:41 UTC) #24
commit-bot: I haz the power
Presubmit check for 10855002-6010 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-09 09:00:57 UTC) #25
Haruki Sato
oops, we still miss some OWNERS lgtm. brettw@, grt@, could you take a look?
8 years, 4 months ago (2012-08-09 13:25:41 UTC) #26
brettw
base lgtm
8 years, 4 months ago (2012-08-10 00:02:20 UTC) #27
Haruki Sato (Google.com)
Thank you all for the review! Adding to CQ. Please let me know if you ...
8 years, 4 months ago (2012-08-10 14:29:11 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10855002/6010
8 years, 4 months ago (2012-08-10 14:29:25 UTC) #29
commit-bot: I haz the power
Try job failure for 10855002-6010 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-10 15:14:10 UTC) #30
satorux1
haruki, the failure seems to be real: E:\b\build\slave\win\build\src\chrome\installer\util\duplicate_tree_detector.cc(32) : error C2143: syntax error : missing ...
8 years, 4 months ago (2012-08-10 17:18:39 UTC) #31
Haruki Sato (Google.com)
On 2012/08/10 17:18:39, satorux1 wrote: > haruki, the failure seems to be real: > > ...
8 years, 4 months ago (2012-08-11 03:45:06 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10855002/11011
8 years, 4 months ago (2012-08-11 03:45:40 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10855002/11011
8 years, 4 months ago (2012-08-11 04:33:29 UTC) #34
commit-bot: I haz the power
8 years, 4 months ago (2012-08-12 01:57:26 UTC) #35
Change committed as 151192

Powered by Google App Engine
This is Rietveld 408576698