Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix missing comma. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
diff --git a/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc b/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
index c069ebb2b976100f9fc2a441ffee8e5ea046e67a..6afad8ff2552675c9633bbd2a871c7a419e5de28 100644
--- a/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
+++ b/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
@@ -65,16 +65,15 @@ SerialPortEnumerator::StringSet SerialPortEnumerator::GenerateValidPatterns() {
SerialPortEnumerator::StringSet
SerialPortEnumerator::GenerateValidSerialPortNames() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- const FilePath DEV_ROOT("/dev");
- const file_util::FileEnumerator::FileType FILES_AND_SYM_LINKS =
- static_cast<file_util::FileEnumerator::FileType>(
- file_util::FileEnumerator::FILES |
- file_util::FileEnumerator::SHOW_SYM_LINKS);
+ const FilePath kDevRoot("/dev");
+ const int kFilesAndSymLinks =
+ file_util::FileEnumerator::FILES |
+ file_util::FileEnumerator::SHOW_SYM_LINKS;
StringSet valid_patterns = GenerateValidPatterns();
StringSet name_set;
file_util::FileEnumerator enumerator(
- DEV_ROOT, false, FILES_AND_SYM_LINKS);
+ kDevRoot, false, kFilesAndSymLinks);
do {
const FilePath next_device_path(enumerator.Next());
const std::string next_device = next_device_path.value();
« no previous file with comments | « chrome/browser/chromeos/login/camera_detector.cc ('k') | chrome/browser/extensions/sandboxed_unpacker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698