Fix for class members cannot have the same name as the class in dart2js

Fix for class members cannot have the same name as the class in dart2js




Fix to 3988: class member cannot have the same names as the class


BUG=dart:3988
TEST=

[ahe, 2012-08-24 08:32:18]

Looking nice, but I'd like to move the error checking to the resolver.

https://chromiumcodereview.appspot.com/10854216/diff/1/lib/compiler/implement...
File lib/compiler/implementation/scanner/class_element_parser.dart (right):

https://chromiumcodereview.appspot.com/10854216/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/class_element_parser.dart:115:
recoverableError('illegal modifier', node: modifiers);
I would rather catch this in the resolver.

https://chromiumcodereview.appspot.com/10854216/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/class_element_parser.dart:123:
recoverableError('illegal modifier', node: modifiers);
Ditto.

https://chromiumcodereview.appspot.com/10854216/diff/1/lib/compiler/implement...
File lib/compiler/implementation/warnings.dart (right):

https://chromiumcodereview.appspot.com/10854216/diff/1/lib/compiler/implement...
lib/compiler/implementation/warnings.dart:82: 'cannot have return type for
constructor');
Please append new error messages just before COMPILER_CRASHED. Also, error
messages should be proper sentences.

[aam-me, 2012-08-25 00:33:43]

Thanks, Peter. Moved the logic to the resolver. Is that what you had in mind?
Please, review.

[ahe, 2012-08-25 04:37:19]

LGTM!

No need to wait for another review when you have addressed the minor nits below.

https://chromiumcodereview.appspot.com/10854216/diff/3002/lib/compiler/implem...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10854216/diff/3002/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:122: if (tree.returnType != null) {
Please use !== until dart2js supports the new equality semantics.

https://chromiumcodereview.appspot.com/10854216/diff/3002/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:296: final mismatchedFlagsBinary =
How about Bits instead of Binary?

https://chromiumcodereview.appspot.com/10854216/diff/3002/lib/compiler/implem...
File lib/compiler/implementation/warnings.dart (right):

https://chromiumcodereview.appspot.com/10854216/diff/3002/lib/compiler/implem...
lib/compiler/implementation/warnings.dart:81: 
extra line

[aam-me, 2012-08-25 10:31:52]

Thanks, Peter, I addressed all the things you pointed out.

[ahe, 2012-08-25 13:27:25]

Still LGTM. I think you should be able to submit this yourself.

[aam-me, 2012-08-26 01:19:38]

Committing as https://chromiumcodereview.appspot.com/10879091/