Fix for class members cannot have the same name as the class in dart2js

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   Type getType(TypeAnnotation annotation);
 }
 
@@ skipping 101 matching lines @@
   TreeElements resolveMethodElement(FunctionElement element) {
     return compiler.withCurrentElement(element, () {
       bool isConstructor = element.kind === ElementKind.GENERATIVE_CONSTRUCTOR;
       if (constructorElements.containsKey(element)) {
         assert(isConstructor);
         TreeElements elements = constructorElements[element];
         if (elements !== null) return elements;
       }
       FunctionExpression tree = element.parseNode(compiler);
       if (isConstructor) {
+        if (tree.returnType !== null) {
+          error(tree, MessageKind.CONSTRUCTOR_WITH_RETURN_TYPE);
+        }
         resolveConstructorImplementation(element, tree);
       }
       ResolverVisitor visitor = new ResolverVisitor(compiler, element);
       visitor.useElement(tree, element);
       visitor.setupFunction(tree, element);
 
       if (isConstructor) {
         // Even if there is no initializer list we still have to do the
         // resolution in case there is an implicit super constructor call.
         InitializerResolver resolver = new InitializerResolver(visitor);
@@ skipping 142 matching lines @@
       ClassResolverVisitor visitor =
         new ClassResolverVisitor(compiler, element);
       visitor.visit(tree);
       element.resolutionState = ClassElement.STATE_DONE;
     }));
   }
 
   void checkMembers(ClassElement cls) {
     if (cls === compiler.objectClass) return;
     cls.forEachMember((holder, member) {
+
+      // Check modifiers.
+      if (member.isFunction() && member.modifiers.isFinal()) {
+        compiler.reportMessage(
+          compiler.spanFromElement(member),
+          MessageKind.ILLEGAL_FINAL_METHOD_MODIFIER.error(),
+          api.Diagnostic.ERROR);
+      }
+      if (member.isConstructor()) {
+        final mismatchedFlagsBits =
+          member.modifiers.flags &
+          (Modifiers.FLAG_STATIC | Modifiers.FLAG_ABSTRACT);
+        if (mismatchedFlagsBits != 0) {
+          final mismatchedFlags =
+            new Modifiers.withFlags(null, mismatchedFlagsBits);
+          compiler.reportMessage(
+            compiler.spanFromElement(member),
+            MessageKind.ILLEGAL_CONSTRUCTOR_MODIFIERS.error([mismatchedFlags]),
+            api.Diagnostic.ERROR);
+        }
+      }
       checkAbstractField(member);
       checkValidOverride(member, cls.lookupSuperMember(member.name));
     });
   }
 
   void checkAbstractField(Element member) {
     if (member is !AbstractFieldElement) return;
     if (member.getter === null) return;
     if (member.setter === null) return;
     int getterFlags = member.getter.modifiers.flags | Modifiers.FLAG_ABSTRACT;
@@ skipping 2145 matching lines @@
   TopScope(LibraryElement library) : super(null, library);
   Element lookup(SourceString name) {
     return library.find(name);
   }
 
   Element add(Element newElement) {
     throw "Cannot add an element in the top scope";
   }
   String toString() => '$element';
 }