ResourceId and unit test cleanup.

ResourceId and unit test cleanup.

* GDataEntry must always be constructed with a valid directory_service ptr. Add a DCHECK for this, and remove runtime tests for null directory_service_ ptr in all methods.
* RemoveEntryFromResourceMap takes resource_id instead of GDataEntry*.
* RemoveEntryFromResourceMap ensures resource_id is non-empty and that an actual deletion occurs every time.
* AddEntryToResourceMap has a DCHECK to guard against multiple additions, or addition of empty resource_id.
* Remove accessors child_files() and child_directories() and make typedefs for GDataFileCollection and GDataDirectoryCollection private.
* Move GetChildDirectoryPaths from gdata_wapi_feed_processor.cc anon namespace to GDataDirectory.
* Fixes for unit tests that added entries with null resource ids, and duplicate resource ids.

BUG=137725
TEST=unit tests.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152151

[achuithb, 2012-08-17 11:06:17]

I was pursuing another CL when it became apparent that this cleanup patch was
necessary. Please take a look.

[satorux1, 2012-08-17 11:49:17]

LGTM with a nit. Nice work.

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_directory_service.h:184: void
RemoveEntryFromResourceMap(const std::string& resource_id);
nice! I guess you'll make it asynchronous in a separate patch.

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files.cc:345: // Recursively extracts the
paths set of all sub-directories.
remove this comment?

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files.h (left):

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files.h:236: }
glad to see them gone.

[achuithb, 2012-08-17 21:02:27]

Thanks for the review!

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10854199/diff/7014/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files.cc:345: // Recursively extracts the
paths set of all sub-directories.
On 2012/08/17 11:49:17, satorux1 wrote:
> remove this comment?

Done.