Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc

Issue 10854199: ResourceId and unit test cleanup. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: minor Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 657 matching lines...) Expand 10 before | Expand all | Expand 10 after
668 GDataEntryProto* dir_base = root_dir->mutable_gdata_entry(); 668 GDataEntryProto* dir_base = root_dir->mutable_gdata_entry();
669 PlatformFileInfoProto* platform_info = dir_base->mutable_file_info(); 669 PlatformFileInfoProto* platform_info = dir_base->mutable_file_info();
670 dir_base->set_title("drive"); 670 dir_base->set_title("drive");
671 dir_base->set_resource_id(kGDataRootDirectoryResourceId); 671 dir_base->set_resource_id(kGDataRootDirectoryResourceId);
672 dir_base->set_upload_url("http://resumable-create-media/1"); 672 dir_base->set_upload_url("http://resumable-create-media/1");
673 platform_info->set_is_directory(true); 673 platform_info->set_is_directory(true);
674 674
675 // drive/File1 675 // drive/File1
676 GDataEntryProto* file = root_dir->add_child_files(); 676 GDataEntryProto* file = root_dir->add_child_files();
677 file->set_title("File1"); 677 file->set_title("File1");
678 file->set_resource_id("resource_id:File1");
678 file->set_upload_url("http://resumable-edit-media/1"); 679 file->set_upload_url("http://resumable-edit-media/1");
679 file->mutable_file_specific_info()->set_file_md5("md5"); 680 file->mutable_file_specific_info()->set_file_md5("md5");
680 platform_info = file->mutable_file_info(); 681 platform_info = file->mutable_file_info();
681 platform_info->set_is_directory(false); 682 platform_info->set_is_directory(false);
682 platform_info->set_size(1048576); 683 platform_info->set_size(1048576);
683 684
684 // drive/Dir1 685 // drive/Dir1
685 GDataDirectoryProto* dir1 = root_dir->add_child_directories(); 686 GDataDirectoryProto* dir1 = root_dir->add_child_directories();
686 dir_base = dir1->mutable_gdata_entry(); 687 dir_base = dir1->mutable_gdata_entry();
687 dir_base->set_title("Dir1"); 688 dir_base->set_title("Dir1");
689 dir_base->set_resource_id("resource_id:Dir1");
688 dir_base->set_upload_url("http://resumable-create-media/2"); 690 dir_base->set_upload_url("http://resumable-create-media/2");
689 platform_info = dir_base->mutable_file_info(); 691 platform_info = dir_base->mutable_file_info();
690 platform_info->set_is_directory(true); 692 platform_info->set_is_directory(true);
691 693
692 // drive/Dir1/File2 694 // drive/Dir1/File2
693 file = dir1->add_child_files(); 695 file = dir1->add_child_files();
694 file->set_title("File2"); 696 file->set_title("File2");
697 file->set_resource_id("resource_id:File2");
695 file->set_upload_url("http://resumable-edit-media/2"); 698 file->set_upload_url("http://resumable-edit-media/2");
696 file->mutable_file_specific_info()->set_file_md5("md5"); 699 file->mutable_file_specific_info()->set_file_md5("md5");
697 platform_info = file->mutable_file_info(); 700 platform_info = file->mutable_file_info();
698 platform_info->set_is_directory(false); 701 platform_info->set_is_directory(false);
699 platform_info->set_size(555); 702 platform_info->set_size(555);
700 703
701 // drive/Dir1/SubDir2 704 // drive/Dir1/SubDir2
702 GDataDirectoryProto* dir2 = dir1->add_child_directories(); 705 GDataDirectoryProto* dir2 = dir1->add_child_directories();
703 dir_base = dir2->mutable_gdata_entry(); 706 dir_base = dir2->mutable_gdata_entry();
704 dir_base->set_title("SubDir2"); 707 dir_base->set_title("SubDir2");
708 dir_base->set_resource_id("resource_id:SubDir2");
705 dir_base->set_upload_url("http://resumable-create-media/3"); 709 dir_base->set_upload_url("http://resumable-create-media/3");
706 platform_info = dir_base->mutable_file_info(); 710 platform_info = dir_base->mutable_file_info();
707 platform_info->set_is_directory(true); 711 platform_info->set_is_directory(true);
708 712
709 // drive/Dir1/SubDir2/File3 713 // drive/Dir1/SubDir2/File3
710 file = dir2->add_child_files(); 714 file = dir2->add_child_files();
711 file->set_title("File3"); 715 file->set_title("File3");
716 file->set_resource_id("resource_id:File3");
712 file->set_upload_url("http://resumable-edit-media/3"); 717 file->set_upload_url("http://resumable-edit-media/3");
713 file->mutable_file_specific_info()->set_file_md5("md5"); 718 file->mutable_file_specific_info()->set_file_md5("md5");
714 platform_info = file->mutable_file_info(); 719 platform_info = file->mutable_file_info();
715 platform_info->set_is_directory(false); 720 platform_info->set_is_directory(false);
716 platform_info->set_size(12345); 721 platform_info->set_size(12345);
717 722
718 // Write this proto out to GCache/vi/meta/file_system.pb 723 // Write this proto out to GCache/vi/meta/file_system.pb
719 std::string serialized_proto; 724 std::string serialized_proto;
720 ASSERT_TRUE(root.SerializeToString(&serialized_proto)); 725 ASSERT_TRUE(root.SerializeToString(&serialized_proto));
721 ASSERT_TRUE(!serialized_proto.empty()); 726 ASSERT_TRUE(!serialized_proto.empty());
(...skipping 1140 matching lines...) Expand 10 before | Expand all | Expand 10 after
1862 1867
1863 // Create directory in root. 1868 // Create directory in root.
1864 FilePath dir_path(FILE_PATH_LITERAL("drive/New Folder 1")); 1869 FilePath dir_path(FILE_PATH_LITERAL("drive/New Folder 1"));
1865 EXPECT_FALSE(EntryExists(dir_path)); 1870 EXPECT_FALSE(EntryExists(dir_path));
1866 AddDirectoryFromFile(dir_path, "directory_entry_atom.json"); 1871 AddDirectoryFromFile(dir_path, "directory_entry_atom.json");
1867 EXPECT_TRUE(EntryExists(dir_path)); 1872 EXPECT_TRUE(EntryExists(dir_path));
1868 1873
1869 EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged( 1874 EXPECT_CALL(*mock_directory_observer_, OnDirectoryChanged(
1870 Eq(FilePath(FILE_PATH_LITERAL("drive/New Folder 1"))))).Times(1); 1875 Eq(FilePath(FILE_PATH_LITERAL("drive/New Folder 1"))))).Times(1);
1871 1876
1872 // Create directory in a sub dirrectory. 1877 // Create directory in a sub directory.
1873 FilePath subdir_path(FILE_PATH_LITERAL("drive/New Folder 1/New Folder 2")); 1878 FilePath subdir_path(FILE_PATH_LITERAL("drive/New Folder 1/New Folder 2"));
1874 EXPECT_FALSE(EntryExists(subdir_path)); 1879 EXPECT_FALSE(EntryExists(subdir_path));
1875 AddDirectoryFromFile(subdir_path, "directory_entry_atom.json"); 1880 AddDirectoryFromFile(subdir_path, "directory_entry_atom2.json");
1876 EXPECT_TRUE(EntryExists(subdir_path)); 1881 EXPECT_TRUE(EntryExists(subdir_path));
1877 } 1882 }
1878 1883
1879 TEST_F(GDataFileSystemTest, FindFirstMissingParentDirectory) { 1884 TEST_F(GDataFileSystemTest, FindFirstMissingParentDirectory) {
1880 LoadRootFeedDocument("root_feed.json"); 1885 LoadRootFeedDocument("root_feed.json");
1881 1886
1882 GURL last_dir_content_url; 1887 GURL last_dir_content_url;
1883 FilePath first_missing_parent_path; 1888 FilePath first_missing_parent_path;
1884 1889
1885 // Create directory in root. 1890 // Create directory in root.
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
2632 2637
2633 // Try to close the same file twice. 2638 // Try to close the same file twice.
2634 file_system_->CloseFile(kFileInRoot, close_file_callback); 2639 file_system_->CloseFile(kFileInRoot, close_file_callback);
2635 message_loop_.Run(); 2640 message_loop_.Run();
2636 2641
2637 // It must fail. 2642 // It must fail.
2638 EXPECT_EQ(GDATA_FILE_ERROR_NOT_FOUND, callback_helper_->last_error_); 2643 EXPECT_EQ(GDATA_FILE_ERROR_NOT_FOUND, callback_helper_->last_error_);
2639 } 2644 }
2640 2645
2641 } // namespace gdata 2646 } // namespace gdata
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698