Chromium Code Reviews| Index: dart/lib/compiler/implementation/ssa/codegen.dart |
| diff --git a/dart/lib/compiler/implementation/ssa/codegen.dart b/dart/lib/compiler/implementation/ssa/codegen.dart |
| index 70014cfcd8bfc91f94cb528b58f17d69770a2186..ce71c331a0129cad1914fcbf824e5bb856c2877c 100644 |
| --- a/dart/lib/compiler/implementation/ssa/codegen.dart |
| +++ b/dart/lib/compiler/implementation/ssa/codegen.dart |
| @@ -1499,7 +1499,14 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor { |
| SourceString name = superMethod.name; |
| fieldName = compiler.namer.instanceFieldName(library, name); |
| } |
| - push(new js.PropertyAccess.field(new js.This(), fieldName), node); |
| + js.PropertyAccess access = |
| + new js.PropertyAccess.field(new js.This(), fieldName); |
|
floitsch
2012/08/15 18:20:47
indent 4.
|
| + if (node.isSetter) { |
| + use(node.inputs[2]); |
|
floitsch
2012/08/15 18:20:47
make this a getter with a telling name.
ahe
2012/08/15 19:10:49
How about:
get rhs {
assert(isSetter);
return
floitsch
2012/08/15 19:26:32
LGTM, but I don't see right now, why the value wou
|
| + push(new js.Assignment(access, pop()), node); |
| + } else { |
| + push(access, node); |
| + } |
| } else { |
| String methodName; |
| if (superMethod.kind == ElementKind.FUNCTION || |