Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 10854128: Bugfix: some circumstances caused an automation reply DCHECK to fail in debug builds. (Closed)

Created:
8 years, 4 months ago by craigdh
Modified:
8 years, 4 months ago
Reviewers:
dtu, jam
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

Bugfix: some circumstances caused an automation reply DCHECK to fail in debug builds. TEST=functional/navigation.py navigation.NavigationTest.testTabsCloseOpen BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
craigdh
dtu: this should fix the issue you're seeing john: OWNERS
8 years, 4 months ago (2012-08-13 19:28:39 UTC) #1
dtu
lgtm
8 years, 4 months ago (2012-08-13 20:30:13 UTC) #2
jam
lgtm
8 years, 4 months ago (2012-08-13 20:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10854128/1
8 years, 4 months ago (2012-08-13 20:53:20 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 22:06:59 UTC) #5
Change committed as 151368

Powered by Google App Engine
This is Rietveld 408576698