Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3642)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10854128: Bugfix: some circumstances caused an automation reply DCHECK to fail in debug builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 86a4a491fddabc65739c5595d834bccc5a088748..0ca507cbd7a8ce1f03237c7cd9054dfee1581001 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -6928,7 +6928,6 @@ void TestingAutomationProvider::DoesAutomationObjectExist(
void TestingAutomationProvider::CloseTabJSON(
DictionaryValue* args, IPC::Message* reply_message) {
- AutomationJSONReply reply(this, reply_message);
Browser* browser;
WebContents* tab;
std::string error;
@@ -6942,17 +6941,17 @@ void TestingAutomationProvider::CloseTabJSON(
}
chrome::CloseWebContents(browser, tab);
if (!wait_until_closed)
- reply.SendSuccess(NULL);
+ AutomationJSONReply(this, reply_message).SendSuccess(NULL);
return;
}
// Close other types of views asynchronously.
RenderViewHost* view;
if (!GetRenderViewFromJSONArgs(args, profile(), &view, &error)) {
- reply.SendError(error);
+ AutomationJSONReply(this, reply_message).SendError(error);
return;
}
view->ClosePage();
- reply.SendSuccess(NULL);
+ AutomationJSONReply(this, reply_message).SendSuccess(NULL);
}
void TestingAutomationProvider::SetViewBounds(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698